Attachment 15264 Details for Bug 9385 – [SIGNED-OFF] Bug 9385 - patron add labels right aligned in chrome

[patch] [SIGNED-OFF] Bug 9385 - patron add labels right aligned in chrome

SIGNED-OFF-Bug-9385---patron-add-labels-right-alig.patch (text/plain), 1.63 KB, created by Nicole C. Engard on 2013-02-11 21:44:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2013-02-11 21:44:53 UTC

Size: 1.63 KB

patch

obsolete

>From fe85cacf8d0133954a6379cdd465f64c6b591f98 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 11 Feb 2013 12:12:58 -0500
>Subject: [PATCH] [SIGNED-OFF] Bug 9385 - patron add labels right aligned in chrome
>
>The <legend> element has been given right alignment which seems to only
>be respected by WebKit-based browsers. Users of Chrome and Safari see a
>right-aligned legend while others see a left-aligned one. Given that the
>legend is often applied to fieldsets spanning much of the screen it
>seems wiser to have them left-aligned.
>
>This patch removes "text-align:right" from the CSS so that <legend> will
>inherit the default left alignment. To test, view any page with a legend
>element, for instance the patron add form. In Firefox, Chrome, Safari,
>IE, etc. the legend ("Patron identity," "Main address," etc.) should be
>left-aligned in the fieldset.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Comment: Works as described. Tested in IE, Chrome, Firefox, Opera.
>No errors.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>All tests pass
>---
> .../intranet-tmpl/prog/en/css/staff-global.css     |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>index 1a3e563..8154304 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>@@ -327,7 +327,6 @@ legend {
>     border:2px solid #b9d8d9;
>     background-color:#ffffff;
>     border-radius:3px;
>-    text-align:right;
>     padding: 0.2em 0.5em;
> }
> 
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 9385: 14571 | 15250 | 15251 | 15264 | 15325