Attachment 152644 Details for Bug 34080 – Bug 34080: Make suggestions_batch_ops a class

[patch] Bug 34080: Make suggestions_batch_ops a class

Bug-34080-Make-suggestionsbatchops-a-class.patch (text/plain), 2.08 KB, created by Sam Lau on 2023-06-23 15:21:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Lau

Created: 2023-06-23 15:21:18 UTC

Size: 2.08 KB

patch

obsolete

>From 9b7d1b794806db27d20ab3b667e795855a406033 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 23 Jun 2023 15:13:42 +0000
>Subject: [PATCH] Bug 34080: Make suggestions_batch_ops a class
>
>To test:
>1. Make some suggestions with different statuses.
>2. Try moving some suggestion to different statuses.
>3. Going from PENDING to another status works fine.
>4. Moving from other status (REJECTED, ORDERED, etc ) will cause a 500 error.
>5. Apply patch
>6. Try 2 - 4 again, no more 500 errors, yay!
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>---
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt    | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 86363cc05f..b1b442d79c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -862,7 +862,7 @@
>                                             <h2>Change selected suggestions</h2>
>                                         </div>
>                                     </div>
>-                                    <div id="suggestions_batch_ops" class="row">
>+                                    <div class="suggestions_batch_ops row">
>                                         <div class="col-sm-4">
>                                             <fieldset class="brief">
>                                                 <div id="select-reason[% loop.index | html %]">
>@@ -1390,7 +1390,7 @@
>                 });
> 
>                 // Note: the selector below passes a second 'context' param - it is not a multiple selector
>-                $("button[type='submit']", "#suggestions_batch_ops").on("click", function(e) {
>+                $("button[type='submit']", ".suggestions_batch_ops").on("click", function(e) {
>                     var submit_button = this;
>                     var form = $(submit_button).parents("form");
>                     var action = $(submit_button).val();
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34080: 152524 | 152643 | 152644 | 152645