Bugzilla – Attachment 152655 Details for
Bug 33972
Remove unnecessary batch status change in C4::ImportBatch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33972: (follow-up) Remove status change to importing
Bug-33972-follow-up-Remove-status-change-to-import.patch (text/plain), 1.56 KB, created by
Katrin Fischer
on 2023-06-23 20:24:04 UTC
(
hide
)
Description:
Bug 33972: (follow-up) Remove status change to importing
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-06-23 20:24:04 UTC
Size:
1.56 KB
patch
obsolete
>From 123032287598f4c09b7bb84d6ca4323473a077d4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 16 Jun 2023 07:45:33 +0000 >Subject: [PATCH] Bug 33972: (follow-up) Remove status change to importing > >It actually is not used, checked, etc. It makes more sense to me to >remove it than to put it before the transaction. >If the transaction succeeds, we end up with imported. It it fails, >we will still be on staged (which is better than importing). >The job will be marked as failed in that case too. > >Note: I am not convinced that this is the definitive solution. This >feels like a workaround. We might still need to dig further. >Are we simply doing too much in this transaction for large staged >imports? Or shouldnt we call Context->dbh constantly in several >subroutines? Is this just a Mariadb bug? No answers yet. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/ImportBatch.pm | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm >index e5c60e0433..cbcdeb5936 100644 >--- a/C4/ImportBatch.pm >+++ b/C4/ImportBatch.pm >@@ -536,8 +536,6 @@ sub BatchCommitRecords { > $progress_interval = 0 unless $progress_interval && $progress_interval =~ /^\d+$/; > $progress_interval = 0 unless ref($progress_callback) eq 'CODE'; > >- SetImportBatchStatus($batch_id, 'importing'); >- > my $schema = Koha::Database->schema; > $schema->txn_begin; > # NOTE: Moved this transaction to the front of the routine. Note that inside the while loop below >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33972
:
152249
|
152400
|
152401
|
152409
|
152410
|
152654
|
152655
|
152738
|
152744