Bugzilla – Attachment 152671 Details for
Bug 34029
Import breaks when data exceeds size of mapped database columns
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34029: (QA follow-up) Fix pushing undef to biblio_ids
Bug-34029-QA-follow-up-Fix-pushing-undef-to-biblio.patch (text/plain), 1.39 KB, created by
Marcel de Rooy
on 2023-06-26 10:54:11 UTC
(
hide
)
Description:
Bug 34029: (QA follow-up) Fix pushing undef to biblio_ids
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-06-26 10:54:11 UTC
Size:
1.39 KB
patch
obsolete
>From 4f3b3b31b8bd5428e2fe516198fe02d2a840da41 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 26 Jun 2023 10:46:17 +0000 >Subject: [PATCH] Bug 34029: (QA follow-up) Fix pushing undef to biblio_ids >Content-Type: text/plain; charset=utf-8 > >See comment1. Although we now fix the error on publishercode, it >is good to verify the result before pushing. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/ImportBatch.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm >index 0945632089..0d6b9fbc1a 100644 >--- a/C4/ImportBatch.pm >+++ b/C4/ImportBatch.pm >@@ -618,7 +618,7 @@ sub BatchCommitRecords { > if ($record_type eq 'biblio') { > my $biblioitemnumber; > ($recordid, $biblioitemnumber) = AddBiblio($marc_record, $framework, { skip_record_index => 1 }); >- push @biblio_ids, $recordid; >+ push @biblio_ids, $recordid if $recordid; > $query = "UPDATE import_biblios SET matched_biblionumber = ? WHERE import_record_id = ?"; # FIXME call SetMatchedBiblionumber instead > if ($item_result eq 'create_new' || $item_result eq 'replace') { > my ($bib_items_added, $bib_items_replaced, $bib_items_errored) = _batchCommitItems($rowref->{'import_record_id'}, $recordid, $item_result, $biblioitemnumber); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34029
:
152404
|
152417
|
152418
|
152490
|
152647
|
152648
|
152670
| 152671 |
152866