Attachment 152747 Details for Bug 33848 – Bug 33848: Enabling Coce in the OPAC breaks cover images on bibliographic detail page

[patch] Bug 33848: Enabling Coce in the OPAC breaks cover images on bibliographic detail page

Bug-33848-Enabling-Coce-in-the-OPAC-breaks-cover-i.patch (text/plain), 2.66 KB, created by Lucas Gass (lukeg) on 2023-06-27 14:15:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-06-27 14:15:15 UTC

Size: 2.66 KB

patch

obsolete

>From 93382c379c1c536646da7874533bee88a999233b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 26 May 2023 17:28:50 +0000
>Subject: [PATCH] Bug 33848: Enabling Coce in the OPAC breaks cover images on
> bibliographic detail page
>
>Bug 32412 added an additional "context" parameter to KOHA.coce.getURL.
>The code which pulls a Coce image for the "main" cover image slider
>needs to include the correct context parameter for the images to load.
>
>This patch also makes a minor correction to CSS in order to make the
>cover image slider "dots" change color to highlight the current slide.
>
>To test, apply the patch and rebuild the OPAC CSS.
>
>- Enable multiple cover image sources in the OPAC including Coce, e.g.
>  Amazon, Google, OpenLibrary, etc.
>- Search for a title which will match multiple cover image sources. In
>  the sample data a search for "Perl" will return good results.
>- Note the number of cover images loading for a title in the search
>  results.
>- View the detail page for that title. There should be the same number
>  of covers in the cover image slider.
>- Clicking the slider navigation dots should work to show each image,
>  and the dot should change color to highlight the current image.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss         | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>index e48225df2e..4564d9b344 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>@@ -736,7 +736,7 @@ th {
>     padding: 10px 5px 5px 5px;
> }
> 
>-.cover-slides {
>+.cover-slider {
>     background: #FFF url( "../images/spinner-small.gif" ) center center no-repeat;
> 
>     .hint {
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 773ff92730..de7cf1e0f0 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -1830,7 +1830,7 @@
>             [% END %]
> 
>             [% IF ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) %]
>-                KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]',[% covernewwindow | html %]);
>+                KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]', $('#biblio-cover-slider') );
>             [% END %]
> 
>             [% IF OpenLibraryCovers %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33848: 151864 | 152722 | 152747 | 154063 | 154064