Bugzilla – Attachment 152749 Details for
Bug 33379
virtualshelfcontents.flags seems useless
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33379: Remove virtualshelfcontents.flags
Bug-33379-Remove-virtualshelfcontentsflags.patch (text/plain), 2.40 KB, created by
Marcel de Rooy
on 2023-06-27 14:43:39 UTC
(
hide
)
Description:
Bug 33379: Remove virtualshelfcontents.flags
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-06-27 14:43:39 UTC
Size:
2.40 KB
patch
obsolete
>From 3b31bd947941bf577c1ce5e1b10da54d7a59550e Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 27 Jun 2023 14:25:44 +0000 >Subject: [PATCH] Bug 33379: Remove virtualshelfcontents.flags >Content-Type: text/plain; charset=utf-8 > >This field is unused. A historic leftover from 2000-2010. > >Test plan: >Run dbrev. >Run prove t/db_dependent/Koha/Virtualshel* > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/atomicupdate/bug33379.pl | 18 ++++++++++++++++++ > installer/data/mysql/kohastructure.sql | 1 - > 2 files changed, 18 insertions(+), 1 deletion(-) > create mode 100755 installer/data/mysql/atomicupdate/bug33379.pl > >diff --git a/installer/data/mysql/atomicupdate/bug33379.pl b/installer/data/mysql/atomicupdate/bug33379.pl >new file mode 100755 >index 0000000000..351baa22da >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug33379.pl >@@ -0,0 +1,18 @@ >+use Modern::Perl; >+ >+return { >+ bug_number => 33379, >+ description => "Remove unused column virtualshelfcontents.flags", >+ up => sub { >+ my ($args) = @_; >+ my ($dbh, $out) = @$args{qw(dbh out)}; >+ if ( column_exists( 'virtualshelfcontents', 'flags' ) ) { >+ $dbh->do( >+ q{ >+ALTER TABLE virtualshelfcontents DROP COLUMN flags; >+ } >+ ); >+ say $out "Removed column 'virtualshelfcontents.flags'"; >+ } >+ }, >+}; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 3f666d2df9..034db4a763 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -5996,7 +5996,6 @@ DROP TABLE IF EXISTS `virtualshelfcontents`; > CREATE TABLE `virtualshelfcontents` ( > `shelfnumber` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key linking to the virtualshelves table, defines the list that this record has been added to', > `biblionumber` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key linking to the biblio table, defines the bib record that has been added to the list', >- `flags` int(11) DEFAULT NULL, > `dateadded` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'date and time this bib record was added to the list', > `borrowernumber` int(11) DEFAULT NULL COMMENT 'borrower number that created this list entry (only the first one is saved: no need for use in/as key)', > KEY `shelfnumber` (`shelfnumber`), >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33379
:
152749
|
152750
|
152770
|
152771
|
153010
|
153011
|
153718