Attachment 152838 Details for Bug 34097 – Bug 34097 - Clicking ellipsis for dateaccessioned plugin shouldn't scroll up

[patch] Bug 34097 - Clicking ellipsis for dateaccessioned plugin shouldn't scroll up

Bug-34097---Clicking-ellipsis-for-dateaccessioned-.patch (text/plain), 1.27 KB, created by Sam Lau on 2023-06-28 18:22:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Lau

Created: 2023-06-28 18:22:20 UTC

Size: 1.27 KB

patch

obsolete

>From 5c7432ab104fc23bc511a53d23a6b6ba3d2eec9b Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Tue, 27 Jun 2023 15:34:59 -0700
>Subject: [PATCH] Bug 34097 - Clicking ellipsis for dateaccessioned plugin
> shouldn't scroll up
>
>Test plan:
>1. Find a record with several items (in ktd "MacLaren's Gaelic
>   self-taught" will do nicely
>2. Click the Edit button next to one of the items
>3. Click the "..." to the right of "d - Date acquired" and verify that the
>   page doesn't scroll up to the top, and that the current date is
>   inserted in the field
>4. Click the "..." to the right of "w - Price effective from" and verify
>   that the page doesn't scroll up and the current date is inserted
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>---
> cataloguing/value_builder/dateaccessioned.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/cataloguing/value_builder/dateaccessioned.pl b/cataloguing/value_builder/dateaccessioned.pl
>index 29aee40581..0c14b96f11 100755
>--- a/cataloguing/value_builder/dateaccessioned.pl
>+++ b/cataloguing/value_builder/dateaccessioned.pl
>@@ -45,6 +45,7 @@ function Focus$function_name(event) {
> 
> function Click$function_name(event) {
>     set_to_today(event.data.id, 1);
>+    return false;
> }
> 
> function set_to_today( id, force ) {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34097: 152772 | 152838 | 153214