Attachment 152850 Details for Bug 34146 – Bug 34146: Add a client-side check with maxlength too

[patch] Bug 34146: Add a client-side check with maxlength too

Bug-34146-Add-a-client-side-check-with-maxlength-t.patch (text/plain), 1.63 KB, created by Martin Renvoize (ashimema) on 2023-06-29 07:00:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-06-29 07:00:22 UTC

Size: 1.63 KB

patch

obsolete

>From 1a55a9d00cb7ec7047ff8e74156f2d8570fcd9c9 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 29 Jun 2023 05:58:29 +0000
>Subject: [PATCH] Bug 34146: Add a client-side check with maxlength too
>
>Test plan:
>Try to add more than 3 characters now in the number of copies.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>index 4c349b37db..454e38dd96 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>@@ -284,7 +284,7 @@
>     </span>
>     <fieldset id="add_multiple_copies_span">
>         <label for="number_of_copies">Number of copies of this item to add: </label>
>-        <input type="text" id="number_of_copies" name="number_of_copies" value="" size="2" />
>+        <input type="text" id="number_of_copies" name="number_of_copies" value="" size="2" maxlength="3" />
>         <input type="submit" id="add_multiple_copies_submit" name="add_multiple_copies_submit" value="Add" onclick="javascript:return Check(this.form) && CheckMultipleAdd(this.form.number_of_copies.value);" /> <a href="#" id="cancel_add_multiple" class="cancel">Cancel</a>
>         <div class="hint"><p>Maximum currently set to 1000. The barcode you enter will be incremented for each additional item.</p></div>
>     </fieldset>
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 34146: 152807 | 152808 | 152843 | 152844 | 152845 | 152846 | 152847 | 152849 | 152850 | 152851