Bugzilla – Attachment 152860 Details for
Bug 33544
Squash some ILL fields to alleviate request table overflow
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33544: WIP Replace title details with one column
Bug-33544-WIP-Replace-title-details-with-one-colum.patch (text/plain), 6.17 KB, created by
Martin Renvoize (ashimema)
on 2023-06-29 11:16:49 UTC
(
hide
)
Description:
Bug 33544: WIP Replace title details with one column
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-06-29 11:16:49 UTC
Size:
6.17 KB
patch
obsolete
>From 7d6dbdabf0aeb54b079dd9c0f9bc2aa698d3aeae Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 5 May 2023 13:44:31 +0100 >Subject: [PATCH] Bug 33544: WIP Replace title details with one column > >Work in progress to combine the request title details fields into one >column for display. > >table_settings needs to be changed to account for the new and missing >fields. >--- > .../prog/en/includes/ill-list-table.inc | 12 ++--- > .../intranet-tmpl/prog/js/ill-list-table.js | 54 ++++--------------- > 2 files changed, 13 insertions(+), 53 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >index 910f3a4f2a..49d41d0805 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >@@ -6,14 +6,8 @@ > <thead> > <tr id="ill_requests_header"> > <th scope="col">Request ID</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="author" data-related-search-on="value">Author</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="title" data-related-search-on="value">Title</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="article_title" data-related-search-on="value">Article title</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="issue" data-related-search-on="value">Issue</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="volume" data-related-search-on="value">Volume</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="year" data-related-search-on="value">Year</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="pages" data-related-search-on="value">Pages</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="type" data-related-search-on="value">Request type</th> >+ <th scope="col">Request details</th> >+ <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="type" data-related-search-on="value">Request type</th> > <th scope="col">Order ID</th> > <th scope="col">Patron</th> > <th scope="col">Bibliographic record ID</th> >@@ -35,4 +29,4 @@ > </thead> > <tbody id="illview-body"> > </tbody> >-</table> >\ No newline at end of file >+</table> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >index 61ed8aaa45..5ecfab36c8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >@@ -206,52 +206,18 @@ $(document).ready(function() { > } > }, > { >- "data": "", // author >+ "data": "", // Request details > "orderable": false, > "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'author'); >- } >- }, >- { >- "data": "", // title >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'title'); >- } >- }, >- { >- "data": "", // article_title >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'article_title'); >- } >- }, >- { >- "data": "", // issue >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'issue'); >- } >- }, >- { >- "data": "", // volume >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'volume'); >- } >- }, >- { >- "data": "", // year >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'year'); >- } >- }, >- { >- "data": "", // pages >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'pages'); >+ let display = ''; >+ display += '<span style="display:block"> Article: ' + display_extended_attribute(row, 'article_title') + '</span>'; >+ display += '<span style="display:block"> Title: ' + display_extended_attribute(row, 'title') + '</span>'; >+ display += '<span style="display:block"> Author: ' + display_extended_attribute(row, 'author') + '</span>'; >+ display += '<span style="display:block"> Issue: ' + display_extended_attribute(row, 'issue') + '</span>'; >+ display += '<span style="display:block"> Volume: ' + display_extended_attribute(row, 'volume') + '</span>'; >+ display += '<span style="display:block"> Year: ' + display_extended_attribute(row, 'year') + '</span>'; >+ display += '<span style="display:block"> Pages: ' + display_extended_attribute(row, 'pages') + '</span>'; >+ return display; > } > }, > { >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33544
:
152860
|
152861
|
152862
|
152863
|
159528
|
159529
|
159530
|
162945
|
162946
|
162947