Attachment 152872 Details for Bug 34124 – Bug 34124: Improve in-page navigation on table settings page

[patch] Bug 34124: Improve in-page navigation on table settings page

Bug-34124-Improve-in-page-navigation-on-table-sett.patch (text/plain), 2.82 KB, created by Sam Lau on 2023-06-29 14:56:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Lau

Created: 2023-06-29 14:56:24 UTC

Size: 2.82 KB

patch

obsolete

>From 33ab2aa08ab29f4d89988d377ec0402284c48e28 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 26 Jun 2023 20:30:56 +0000
>Subject: [PATCH] Bug 34124: Improve in-page navigation on table settings page
>
>This patch adds links to the table settings page so that the user can
>jump directly to a particular table within a page section.
>
>The patch also changes the logic of when in-page links are displayed: I
>think it makes sense not to show a "Jump to page" link when there is
>only one page. The page will show a "Jump to table" link only if there
>is only one table.
>
>To test, apply the patch and go to Adinistration -> Table settings.
>
>- Expand and check multiple sections.
>- In the "Administration" section, there are multiple pages.
>  - Check that the "Jump to page" links work correctly.
>- In the "Catalog" section, there is only one page: "detail."
>  - Check that the "Jump to table" links work correctly.
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>---
> .../prog/en/modules/admin/columns_settings.tt        | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
>index bd8c826f27..149f46b699 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
>@@ -3,8 +3,8 @@
> [% USE TablesSettings %]
> [% SET footerjs = 1 %]
> [% BLOCK pagelist %]
>-    [% IF module.keys and module.keys.size > 0 %]
>-        <span>Jump to:</span>
>+    [% IF module.keys and module.keys.size > 1 %]
>+        <span>Jump to page:</span>
>         [% FOR pagename IN module.keys.sort %]
>             <a href="#[% pagename | url %]">[% pagename | html %]</a>
>             [% UNLESS loop.last %]<span class="separator"> | </span>[% END %]
>@@ -18,6 +18,14 @@
>                 [% FOR pagename IN module.keys.sort %]
>                     <h4 class="page_name" id="[% pagename | html %]">Page: [% pagename | html %]</h4>
>                     [% SET tables = module %]
>+                    [% IF tables.$pagename.keys and tables.$pagename.keys.size > 1 %]
>+                        Jump to table:
>+                        [% FOR tablename IN tables.$pagename.keys.sort %]
>+                            [% SET table_id = pagename _ '#' _ tablename %]
>+                            <a href="#[% table_id | uri %]">[% tablename | html %]</a>
>+                            [% UNLESS loop.last %]<span class="separator"> | </span>[% END %]
>+                        [% END %]
>+                    [% END %]
>                     [% IF tables.$pagename.keys and tables.$pagename.keys.size > 0 %]
>                         [% FOR tablename IN tables.$pagename.keys.sort %]
>                             [% SET table_id = pagename _ '#' _ tablename %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34124: 152703 | 152872 | 152926 | 153115