Bugzilla – Attachment 152885 Details for
Bug 34092
patron-autocomplete.js and patron-search.inc search logic should match
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34092: (QA follow-up) Typo and removing unneeded spread
Bug-34092-QA-follow-up-Typo-and-removing-unneeded-.patch (text/plain), 1.72 KB, created by
Marcel de Rooy
on 2023-06-30 07:14:02 UTC
(
hide
)
Description:
Bug 34092: (QA follow-up) Typo and removing unneeded spread
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-06-30 07:14:02 UTC
Size:
1.72 KB
patch
obsolete
>From 628619a5db00b3a7fd8b479d282064a9e1a46f90 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 30 Jun 2023 06:55:29 +0000 >Subject: [PATCH] Bug 34092: (QA follow-up) Typo and removing unneeded spread >Content-Type: text/plain; charset=utf-8 > >Typo patron_searh_js. >The spread is not needed; the function checks for defined later. > >Note for QA/RM: Ignore this qa tools warning: > forbidden pattern: console.log (line 211) >This is an intended console warning. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index 5f81ea14c7..7fffda2227 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -208,7 +208,7 @@ > [% BLOCK patron_search_js %] > > [% IF redirect_if_one_result && !redirect_url %] >- <script>console.log("Wrong call of patron_searh_js - missing redirect_url");</script> >+ <script>console.log("Wrong call of patron_search_js - missing redirect_url");</script> > [% END %] > > [% INCLUDE 'select2.inc' %] >@@ -328,7 +328,7 @@ > { > search_type: search_type, > search_fields: search_fields, >- ...(typeof extended_attribute_types != 'undefined' && {extended_attribute_types: extended_attribute_types}) >+ extended_attribute_types: extended_attribute_types, > } > ); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34092
:
152682
|
152683
|
152684
|
152698
|
152830
|
152831
|
152832
|
152854
|
152855
|
152856
|
152882
|
152883
|
152884
|
152885
|
152891