Attachment 152939 Details for Bug 30708 – Bug 30708: Add REST API controllers

[patch] Bug 30708: Add REST API controllers

Bug-30708-Add-REST-API-controllers.patch (text/plain), 25.33 KB, created by Jonathan Druart on 2023-07-03 13:26:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-07-03 13:26:57 UTC

Size: 25.33 KB

patch

obsolete

>From f3269f611125cc9906eb5bdf9a8b43afac3a1c74 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 7 Apr 2023 14:47:45 +0200
>Subject: [PATCH] Bug 30708: Add REST API controllers
>
>Sponsored-by: BULAC - http://www.bulac.fr/
>---
> Koha/REST/V1/Preservation/Processings.pm | 250 +++++++++++++
> Koha/REST/V1/Preservation/Trains.pm      | 441 +++++++++++++++++++++++
> Koha/REST/V1/Preservation/WaitingList.pm | 162 +++++++++
> 3 files changed, 853 insertions(+)
> create mode 100644 Koha/REST/V1/Preservation/Processings.pm
> create mode 100644 Koha/REST/V1/Preservation/Trains.pm
> create mode 100644 Koha/REST/V1/Preservation/WaitingList.pm
>
>diff --git a/Koha/REST/V1/Preservation/Processings.pm b/Koha/REST/V1/Preservation/Processings.pm
>new file mode 100644
>index 00000000000..6b04e9b2f5d
>--- /dev/null
>+++ b/Koha/REST/V1/Preservation/Processings.pm
>@@ -0,0 +1,250 @@
>+package Koha::REST::V1::Preservation::Processings;
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Mojo::Base 'Mojolicious::Controller';
>+
>+use Koha::Preservation::Processings;
>+
>+use Scalar::Util qw( blessed );
>+use Try::Tiny;
>+=head1 API
>+
>+=head2 Methods
>+
>+=head3 list
>+
>+=cut
>+
>+sub list {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    return try {
>+        my $processings_set = Koha::Preservation::Processings->new;
>+        my $processings = $c->objects->search( $processings_set );
>+        return $c->render( status => 200, openapi => $processings );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 get
>+
>+Controller function that handles retrieving a single Koha::Preservation::Processing object
>+
>+=cut
>+
>+sub get {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    return try {
>+        my $processing_id = $c->validation->param('processing_id');
>+        my $processing    = $c->objects->find( Koha::Preservation::Processings->search, $processing_id );
>+
>+        unless ($processing) {
>+            return $c->render(
>+                status  => 404,
>+                openapi => { error => "Processing not found" }
>+            );
>+        }
>+
>+        return $c->render(
>+            status  => 200,
>+            openapi => $processing
>+        );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 add
>+
>+Controller function that handles adding a new Koha::Preservation::Processing object
>+
>+=cut
>+
>+sub add {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    return try {
>+        Koha::Database->new->schema->txn_do(
>+            sub {
>+
>+                my $body = $c->validation->param('body');
>+
>+                my $attributes = delete $body->{attributes} // [];
>+
>+                my $processing = Koha::Preservation::Processing->new_from_api($body)->store;
>+                $processing->attributes($attributes);
>+
>+                $c->res->headers->location($c->req->url->to_string . '/' . $processing->processing_id);
>+                return $c->render(
>+                    status  => 201,
>+                    openapi => $processing->to_api
>+                );
>+            }
>+        );
>+    }
>+    catch {
>+
>+        my $to_api_mapping = Koha::Preservation::Processing->new->to_api_mapping;
>+
>+        if ( blessed $_ ) {
>+            if ( $_->isa('Koha::Exceptions::Object::DuplicateID') ) {
>+                return $c->render(
>+                    status  => 409,
>+                    openapi => { error => $_->error, conflict => $_->duplicate_id }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::Object::FKConstraint') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => {
>+                            error => "Given "
>+                            . $to_api_mapping->{ $_->broken_fk }
>+                            . " does not exist"
>+                    }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::BadParameter') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => {
>+                            error => "Given "
>+                            . $to_api_mapping->{ $_->parameter }
>+                            . " does not exist"
>+                    }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::PayloadTooLarge') ) {
>+                return $c->render(
>+                    status  => 413,
>+                    openapi => { error => $_->error }
>+                );
>+            }
>+        }
>+
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 update
>+
>+Controller function that handles updating a Koha::Preservation::Processing object
>+
>+=cut
>+
>+sub update {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    my $processing_id = $c->validation->param('processing_id');
>+    my $processing = Koha::Preservation::Processings->find( $processing_id );
>+
>+    unless ($processing) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Processing not found" }
>+        );
>+    }
>+
>+    return try {
>+        Koha::Database->new->schema->txn_do(
>+            sub {
>+
>+                my $body = $c->validation->param('body');
>+
>+                my $attributes = delete $body->{attributes} // [];
>+
>+                $processing->set_from_api($body)->store;
>+                $processing->attributes($attributes);
>+
>+
>+                $c->res->headers->location($c->req->url->to_string . '/' . $processing->processing_id);
>+                return $c->render(
>+                    status  => 200,
>+                    openapi => $processing->to_api
>+                );
>+            }
>+        );
>+    }
>+    catch {
>+        my $to_api_mapping = Koha::Preservation::Processing->new->to_api_mapping;
>+
>+        if ( blessed $_ ) {
>+            if ( $_->isa('Koha::Exceptions::Object::FKConstraint') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => {
>+                            error => "Given "
>+                            . $to_api_mapping->{ $_->broken_fk }
>+                            . " does not exist"
>+                    }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::BadParameter') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => {
>+                            error => "Given "
>+                            . $to_api_mapping->{ $_->parameter }
>+                            . " does not exist"
>+                    }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::PayloadTooLarge') ) {
>+                return $c->render(
>+                    status  => 413,
>+                    openapi => { error => $_->error }
>+                );
>+            }
>+        }
>+
>+        $c->unhandled_exception($_);
>+    };
>+};
>+
>+=head3 delete
>+
>+=cut
>+
>+sub delete {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    my $processing = Koha::Preservation::Processings->find( $c->validation->param('processing_id') );
>+    unless ($processing) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Processing not found" }
>+        );
>+    }
>+
>+    return try {
>+        $processing->delete;
>+        return $c->render(
>+            status  => 204,
>+            openapi => q{}
>+        );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+1;
>diff --git a/Koha/REST/V1/Preservation/Trains.pm b/Koha/REST/V1/Preservation/Trains.pm
>new file mode 100644
>index 00000000000..51dc2982460
>--- /dev/null
>+++ b/Koha/REST/V1/Preservation/Trains.pm
>@@ -0,0 +1,441 @@
>+package Koha::REST::V1::Preservation::Trains;
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Mojo::Base 'Mojolicious::Controller';
>+
>+use Koha::Preservation::Trains;
>+use Koha::Preservation::Train::Items;
>+
>+use Scalar::Util qw( blessed );
>+use Try::Tiny;
>+
>+=head1 API
>+
>+=head2 Methods
>+
>+=head3 list
>+
>+Controller function that handles listing the items from a train
>+
>+=cut
>+
>+sub list {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    return try {
>+        my $trains_set = Koha::Preservation::Trains->new;
>+        my $trains = $c->objects->search( $trains_set );
>+        return $c->render( status => 200, openapi => $trains );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 get
>+
>+Controller function that handles retrieving a single Koha::Preservation::Train object
>+
>+=cut
>+
>+sub get {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    return try {
>+        my $train_id = $c->validation->param('train_id');
>+        my $train    = $c->objects->find( Koha::Preservation::Trains->search, $train_id );
>+
>+        unless ($train) {
>+            return $c->render(
>+                status  => 404,
>+                openapi => { error => "Train not found" }
>+            );
>+        }
>+
>+        return $c->render(
>+            status  => 200,
>+            openapi => $train
>+        );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 add
>+
>+Controller function that handles adding a new Koha::Preservation::Train object
>+
>+=cut
>+
>+sub add {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    return try {
>+        Koha::Database->new->schema->txn_do(
>+            sub {
>+
>+                my $body = $c->validation->param('body');
>+
>+                my $train = Koha::Preservation::Train->new_from_api($body)->store;
>+
>+                $c->res->headers->location($c->req->url->to_string . '/' . $train->train_id);
>+                return $c->render(
>+                    status  => 201,
>+                    openapi => $train->to_api
>+                );
>+            }
>+        );
>+    }
>+    catch {
>+
>+        my $to_api_mapping = Koha::Preservation::Train->new->to_api_mapping;
>+
>+        if ( blessed $_ ) {
>+            if ( $_->isa('Koha::Exceptions::Object::DuplicateID') ) {
>+                return $c->render(
>+                    status  => 409,
>+                    openapi => { error => $_->error, conflict => $_->duplicate_id }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::Object::FKConstraint') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => {
>+                            error => "Given "
>+                            . $to_api_mapping->{ $_->broken_fk }
>+                            . " does not exist"
>+                    }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::BadParameter') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => {
>+                            error => "Given "
>+                            . $to_api_mapping->{ $_->parameter }
>+                            . " does not exist"
>+                    }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::PayloadTooLarge') ) {
>+                return $c->render(
>+                    status  => 413,
>+                    openapi => { error => $_->error }
>+                );
>+            }
>+        }
>+
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 update
>+
>+Controller function that handles updating a Koha::Preservation::Train object
>+
>+=cut
>+
>+sub update {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    my $train_id = $c->validation->param('train_id');
>+    my $train = Koha::Preservation::Trains->find( $train_id );
>+
>+    unless ($train) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Train not found" }
>+        );
>+    }
>+
>+    return try {
>+        Koha::Database->new->schema->txn_do(
>+            sub {
>+
>+                my $body = $c->validation->param('body');
>+
>+                $train->set_from_api($body)->store;
>+
>+                $c->res->headers->location($c->req->url->to_string . '/' . $train->train_id);
>+                return $c->render(
>+                    status  => 200,
>+                    openapi => $train->to_api
>+                );
>+            }
>+        );
>+    }
>+    catch {
>+        my $to_api_mapping = Koha::Preservation::Train->new->to_api_mapping;
>+
>+        if ( blessed $_ ) {
>+            if ( $_->isa('Koha::Exceptions::Object::FKConstraint') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => {
>+                            error => "Given "
>+                            . $to_api_mapping->{ $_->broken_fk }
>+                            . " does not exist"
>+                    }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::BadParameter') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => {
>+                            error => "Given "
>+                            . $to_api_mapping->{ $_->parameter }
>+                            . " does not exist"
>+                    }
>+                );
>+            }
>+            elsif ( $_->isa('Koha::Exceptions::PayloadTooLarge') ) {
>+                return $c->render(
>+                    status  => 413,
>+                    openapi => { error => $_->error }
>+                );
>+            }
>+        }
>+
>+        $c->unhandled_exception($_);
>+    };
>+};
>+
>+=head3 delete
>+
>+Controller function that handles deleting a Koha::Preservation::Train object
>+
>+=cut
>+
>+sub delete {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    my $train = Koha::Preservation::Trains->find( $c->validation->param('train_id') );
>+    unless ($train) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Train not found" }
>+        );
>+    }
>+
>+    return try {
>+        $train->delete;
>+        return $c->render(
>+            status  => 204,
>+            openapi => q{}
>+        );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 get_item
>+
>+Controller function that handles getting an item from a train
>+
>+=cut
>+
>+sub get_item {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    my $train_id = $c->validation->param('train_id');
>+    my $train = Koha::Preservation::Trains->find( $train_id );
>+
>+    unless ($train) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Train not found" }
>+        );
>+    }
>+
>+    my $train_item_id = $c->validation->param('train_item_id');
>+
>+    my $train_item = $c->objects->find(Koha::Preservation::Train::Items->search, { train_item_id => $train_item_id, train_id => $train_id });
>+
>+    unless ($train_item) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Item not found" }
>+        );
>+    }
>+
>+    return try {
>+        Koha::Database->new->schema->txn_do(
>+            sub {
>+                return $c->render( status => 200, openapi => $train_item );
>+            }
>+        );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 add_item
>+
>+Controller function that handles adding items in batch to a train
>+
>+=cut
>+
>+sub add_item {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    my $train_id = $c->validation->param('train_id');
>+    my $train = Koha::Preservation::Trains->find( $train_id );
>+
>+    unless ($train) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Train not found" }
>+        );
>+    }
>+
>+    my $body = $c->validation->param('body');
>+    return try {
>+        Koha::Database->new->schema->txn_do(
>+            sub {
>+                my $attributes = delete $body->{attributes} // [];
>+                my $train_item = $train->add_item($body);
>+                $train_item->attributes($attributes);
>+                return $c->render( status => 201, openapi => $train_item );
>+              }
>+        );
>+    }
>+    catch {
>+        if ( blessed $_ ) {
>+            if ( $_->isa('Koha::Exceptions::Preservation::MissingSettings') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => { error => "MissingSettings", parameter => $_->parameter }
>+                );
>+            } elsif ( $_->isa('Koha::Exceptions::Preservation::ItemNotFound') ) {
>+                return $c->render(
>+                    status  => 404,
>+                    openapi => { error => "Item not found" }
>+                );
>+            } elsif ( $_->isa('Koha::Exceptions::Object::DuplicateID') ) {
>+                return $c->render(
>+                    status  => 409,
>+                    openapi => { error => $_->error, conflict => $_->duplicate_id }
>+                );
>+            } elsif ( $_->isa('Koha::Exceptions::Preservation::ItemNotInWaitingList') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => { error => 'Item not in waiting list' }
>+                );
>+            }
>+        }
>+
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 update_item
>+
>+Controller function that handles updating an item from a train
>+
>+=cut
>+
>+sub update_item {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    my $train_id = $c->validation->param('train_id');
>+    my $train = Koha::Preservation::Trains->find( $train_id );
>+
>+    unless ($train) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Train not found" }
>+        );
>+    }
>+
>+    my $train_item_id = $c->validation->param('train_item_id');
>+
>+    my $train_item = Koha::Preservation::Train::Items->search({ train_item_id => $train_item_id, train_id => $train_id })->single;
>+
>+    unless ($train_item) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Item not found" }
>+        );
>+    }
>+
>+    return try {
>+        Koha::Database->new->schema->txn_do(
>+            sub {
>+                my $body       = $c->validation->param('body');
>+                my $attributes = delete $body->{attributes} // [];
>+
>+                $train_item->set_from_api($body)->store;
>+                $train_item->attributes($attributes);
>+                return $c->render( status => 200, openapi => $train_item );
>+              }
>+        );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+
>+=head3 remove_item
>+
>+Controller function that handles removing an item from a train
>+
>+=cut
>+
>+sub remove_item {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    my $train_id = $c->validation->param('train_id');
>+    my $train = Koha::Preservation::Trains->find( $train_id );
>+
>+    unless ($train) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Train not found" }
>+        );
>+    }
>+
>+    my $train_item_id = $c->validation->param('train_item_id');
>+
>+    my $train_item = $train->items->find($train_item_id);
>+
>+    unless ($train_item) {
>+        return $c->render(
>+            status  => 404,
>+            openapi => { error => "Train item not found" }
>+        );
>+    }
>+
>+    return try {
>+        $train_item->delete;
>+
>+        return $c->render(
>+            status  => 204,
>+            openapi => q{}
>+        );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+1;
>diff --git a/Koha/REST/V1/Preservation/WaitingList.pm b/Koha/REST/V1/Preservation/WaitingList.pm
>new file mode 100644
>index 00000000000..cc2c335e271
>--- /dev/null
>+++ b/Koha/REST/V1/Preservation/WaitingList.pm
>@@ -0,0 +1,162 @@
>+package Koha::REST::V1::Preservation::WaitingList;
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Mojo::Base 'Mojolicious::Controller';
>+
>+use Koha::Preservation::Train::Items;
>+use Koha::Items;
>+use Koha::Exceptions::Preservation;
>+
>+use Scalar::Util qw( blessed );
>+use Try::Tiny;
>+
>+=head1 API
>+
>+=head2 Methods
>+
>+=head3 list
>+
>+Controller function that handles listing the items from the waiting list
>+
>+=cut
>+
>+sub list {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    return try {
>+        my $not_for_loan = C4::Context->preference('PreservationNotForLoanWaitingListIn');
>+        Koha::Exceptions::Preservation::MissingSettings->throw( parameter => 'PreservationNotForLoanWaitingListIn' ) unless $not_for_loan;
>+
>+        my $items_set = Koha::Items->new->search({ notforloan => $not_for_loan });
>+        my $items     = $c->objects->search( $items_set );
>+        return $c->render(
>+            status  => 200,
>+            openapi => $items
>+        );
>+    }
>+    catch {
>+        if ( blessed $_ ) {
>+            if ( $_->isa('Koha::Exceptions::Preservation::MissingSettings') ) {
>+                return $c->render(
>+                    status  => 400,
>+                    openapi => { error => "MissingSettings", parameter => $_->parameter }
>+                );
>+            }
>+        }
>+
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 add_items
>+
>+Controller function that handles adding items to the waiting list
>+
>+=cut
>+
>+sub add_items {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    return try {
>+        my $body = $c->validation->every_param('body');
>+        my $new_not_for_loan = C4::Context->preference('PreservationNotForLoanWaitingListIn');
>+
>+        Koha::Exceptions::Preservation::MissingSettings->throw( parameter => 'PreservationNotForLoanWaitingListIn' ) unless $new_not_for_loan;
>+
>+        my @items;
>+        for my $item_id ( @$body ) {
>+            try {
>+                while ( my ( $k, $v ) = each %$item_id ) {
>+
>+                    my $key  = $k eq 'item_id' ? 'itemnumber' : 'barcode';
>+                    my $item = Koha::Items->find( { $key => $v } );
>+                    next unless $item; # FIXME Must return a multi-status response 207
>+                    if ( $item->notforloan != $new_not_for_loan ) {
>+                        my $already_in_train = Koha::Preservation::Train::Items->search(
>+                            {
>+                                item_id => $item->itemnumber,
>+                                'train.received_on' => undef,
>+                            },
>+                            {
>+                                join => 'train',
>+                            }
>+                        )->count;
>+                        if ( $already_in_train ) {
>+                            Koha::Exceptions::Preservation::ItemAlreadyInTrain->throw;
>+                        }
>+
>+                        $item->notforloan($new_not_for_loan)->store;
>+                        push @items, { item_id => $item->itemnumber };
>+                    }
>+                }
>+            } catch {
>+                warn $_;
>+            };
>+        }
>+        return $c->render( status => 201, openapi => \@items );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+=head3 remove_item
>+
>+Controller function that handles removing an item from the waiting list
>+
>+=cut
>+
>+sub remove_item {
>+    my $c = shift->openapi->valid_input or return;
>+
>+    return try {
>+        my $item_id = $c->validation->param('item_id');
>+
>+        my $item = Koha::Items->find($item_id);
>+
>+        unless ($item) {
>+            return $c->render(
>+                status  => 404,
>+                openapi => { error => "Item not found" }
>+            );
>+        }
>+
>+        my $not_for_loan_waiting_list_in = C4::Context->preference('PreservationNotForLoanWaitingListIn');
>+        if ($item->notforloan ne $not_for_loan_waiting_list_in) {
>+            unless ($item) {
>+                return $c->render(
>+                    status  => 404,
>+                    openapi => { error => "Item not in waiting list found" }
>+                );
>+            }
>+        }
>+
>+        $item->notforloan(0)->store;
>+
>+        return $c->render(
>+            status  => 204,
>+            openapi => q{}
>+        );
>+    }
>+    catch {
>+        $c->unhandled_exception($_);
>+    };
>+}
>+
>+1;
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 30708: 134715 | 134716 | 134732 | 134733 | 134734 | 134736 | 134737 | 134738 | 134782 | 134783 | 134784 | 134785 | 152939 | 152940 | 152941 | 152942 | 152943 | 152944 | 152945 | 152946 | 152947 | 152948 | 152949 | 152950 | 152951 | 152952 | 152953 | 152954 | 152955 | 152956 | 152957 | 152958 | 152959 | 152960 | 152961 | 152962 | 152963 | 152964 | 152965 | 152966 | 152967 | 152968 | 152969 | 152970 | 153102 | 153576 | 154167 | 154168 | 154169 | 154170 | 154171 | 154172 | 154173 | 154174 | 154175 | 154176 | 154177 | 154178 | 154179 | 154180 | 154181 | 154182 | 154183 | 154184 | 154185 | 154186 | 154187 | 154188 | 154189 | 154190 | 154191 | 154192 | 154193 | 154194 | 154195 | 154196 | 154197 | 154198 | 154199 | 154200 | 154201 | 154202 | 154203 | 156592 | 156596 | 156597 | 156636 | 156637 | 156638 | 156639 | 156640 | 156641 | 156642 | 156643 | 156644 | 156645 | 156646 | 156647 | 156648 | 156649 | 156650 | 156651 | 156652 | 156653 | 156654 | 156655 | 156656 | 156657 | 156658 | 156659 | 156660 | 156661 | 156662 | 156663 | 156664 | 156665 | 156666 | 156667 | 156668 | 156669 | 156670 | 156671 | 156672 | 156673 | 156674 | 156675 | 157502 | 157503 | 157506 | 157508 | 157512 | 157514 | 157557