Attachment 152977 Details for Bug 33999 – Bug 33999: Subscription details link on bibliographic detail page should have permission check

[patch] Bug 33999: Subscription details link on bibliographic detail page should have permission check

Bug-33999-Subscription-details-link-on-bibliograph.patch (text/plain), 1.86 KB, created by Martin Renvoize (ashimema) on 2023-07-03 13:55:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-07-03 13:55:59 UTC

Size: 1.86 KB

patch

obsolete

>From 6f7a17c068afdf36a2c5f6175b6f7d5f3258201e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 13 Jun 2023 14:11:33 +0000
>Subject: [PATCH] Bug 33999: Subscription details link on bibliographic detail
> page should have permission check
>
>This patch wraps the "Subscription details" link on the bibliographic
>detail page with a permissions check, "CAN_user_serials," so that a user
>lacking permission to access the Serials module will not be shown the
>link.
>
>To test, apply the patch and view the bibliographic detail page of a
>serial record.
>
>- When viewing the "Subscriptions" tab as a user with Serials
>  permissions you should see the "Subscription details" link.
>- When viewing the tab as a user without the correct permissions the
>  link should not be present.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index d4ead1659f..c4b4e9d3b8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -810,7 +810,11 @@
>             [% END %]
>             </table>
>             [% END %]
>-            <a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscription.subscriptionid | uri %]">Subscription details</a>
>+            [% IF ( CAN_user_serials ) %]
>+                <p>
>+                    <a class="btn btn-default" href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscription.subscriptionid | uri %]">Subscription details</a>
>+                </p>
>+            [% END %]
>     [% END %]
> </div>
> </div>
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 33999: 152314 | 152320 | 152687 | 152977 | 152978