Attachment 152997 Details for Bug 34088 – Bug 34088: Fix qa script issues

[patch] Bug 34088: Fix qa script issues

Bug-34088-Fix-qa-script-issues.patch (text/plain), 1.71 KB, created by David Cook on 2023-07-04 02:01:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2023-07-04 02:01:54 UTC

Size: 1.71 KB

patch

obsolete

>From 1b597a838308bdb476ee47171f172b47a59b176f Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Tue, 4 Jul 2023 02:01:25 +0000
>Subject: [PATCH] Bug 34088: Fix qa script issues
>
>---
> Koha/Installer.pm                      | 16 ++++++++++++++--
> installer/data/mysql/updatedatabase.pl |  4 ++--
> 2 files changed, 16 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Installer.pm b/Koha/Installer.pm
>index ec975e979e..48f8fc0f01 100644
>--- a/Koha/Installer.pm
>+++ b/Koha/Installer.pm
>@@ -6,6 +6,18 @@ require Koha;
> require Koha::Database;
> require Koha::Config;
> 
>+=head1 API
>+
>+=head2 Class methods
>+
>+=head3 needs_update
>+
>+Determines if an update is needed by checking
>+the database version, the code version, and whether
>+there are any atomic updates available.
>+
>+=cut
>+
> sub needs_update {
>     my $needs_update = 1;
>     my $dbh          = Koha::Database::dbh();
>@@ -30,7 +42,7 @@ sub needs_update {
>     return $needs_update;
> }
> 
>-=head2 TransformToNum
>+=head3 TransformToNum
> 
> Transform the Koha version from a 4 parts string
> to a number, with just 1 .
>@@ -50,7 +62,7 @@ sub TransformToNum {
>     return $version;
> }
> 
>-=head2 get_atomic_updates
>+=head3 get_atomic_updates
> 
> Get atomic database updates
> 
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 34d9fde66d..9f3ccefe70 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -27,6 +27,8 @@
> 
> # NOTE: Please keep the version in kohaversion.pl up-to-date!
> 
>+use Modern::Perl;
>+
> BEGIN {
>     use Koha::Installer;
>     if ( !Koha::Installer->needs_update ) {
>@@ -34,8 +36,6 @@ BEGIN {
>     }
> }
> 
>-use Modern::Perl;
>-
> use feature 'say';
> 
> # CPAN modules
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34088: 152543 | 152995 | 152996 | 152997 | 152998 | 154230 | 170554 | 170555 | 171050 | 174441 | 174443