Bugzilla – Attachment 153146 Details for
Bug 34212
Bug 23336 follow-up code improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34212: Compare strings with eq instead of ==
Bug-34212-Compare-strings-with-eq-instead-of-.patch (text/plain), 845 bytes, created by
Martin Renvoize (ashimema)
on 2023-07-07 09:55:43 UTC
(
hide
)
Description:
Bug 34212: Compare strings with eq instead of ==
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-07-07 09:55:43 UTC
Size:
845 bytes
patch
obsolete
>From 7da1a8db97fa4606714258e46ae90faf399cfd66 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 6 Jul 2023 15:41:15 +0200 >Subject: [PATCH] Bug 34212: Compare strings with eq instead of == > >And don't ignore warnings next time ;) > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Token.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Token.pm b/Koha/Token.pm >index 62b5a6c739..b7cdd3ad96 100644 >--- a/Koha/Token.pm >+++ b/Koha/Token.pm >@@ -295,7 +295,7 @@ sub _chk_jwt { > > my $claims = Mojo::JWT->new(secret => $params->{secret})->decode($params->{token}); > >- return 1 if exists $claims->{id} && $claims->{id} == $params->{id}; >+ return 1 if exists $claims->{id} && $claims->{id} eq $params->{id}; > } > > sub _decode_jwt { >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34212
:
153084
|
153145
| 153146 |
153147