Bugzilla – Attachment 153147 Details for
Bug 34212
Bug 23336 follow-up code improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34212: Fix tests
Bug-34212-Fix-tests.patch (text/plain), 1.79 KB, created by
Martin Renvoize (ashimema)
on 2023-07-07 09:55:45 UTC
(
hide
)
Description:
Bug 34212: Fix tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-07-07 09:55:45 UTC
Size:
1.79 KB
patch
obsolete
>From 107c20b0ac03f5de3ad219501921f775e3465cc7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 6 Jul 2023 15:41:40 +0200 >Subject: [PATCH] Bug 34212: Fix tests > >Not sure what we were trying to do, but apparently we only use the keys >to generate the id string. How did "please" end up here? > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/api/v1/checkouts.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/api/v1/checkouts.t b/t/db_dependent/api/v1/checkouts.t >index 2e749aa874..1522e6b0ff 100755 >--- a/t/db_dependent/api/v1/checkouts.t >+++ b/t/db_dependent/api/v1/checkouts.t >@@ -321,7 +321,7 @@ subtest 'get_availability' => sub { > > # Needs confirm > %needsconfirmation = ( confirm1 => 1, confirm2 => 'please' ); >- my $token = Koha::Token->new->generate_jwt( { id => $librarian->id . ":" . $item1_id . ":confirm1:confirm2:please" }); >+ my $token = Koha::Token->new->generate_jwt( { id => $librarian->id . ":" . $item1_id . ":confirm1:confirm2" }); > $t->get_ok( > "//$userid:$password@/api/v1/checkouts/availability?item_id=$item1_id&patron_id=$patron_id" > )->status_is(200)->json_is( '/blockers' => {} ) >@@ -334,7 +334,7 @@ subtest 'get_availability' => sub { > { > id => $librarian->id . ":" > . $item1_id >- . ":confirm1:confirm2:please", >+ . ":confirm1:confirm2", > token => $confirmation_token > } > ), >@@ -415,7 +415,7 @@ subtest 'add checkout' => sub { > { > id => $librarian->id . ":" > . $item1_id >- . ":confirm1:confirm2:please" >+ . ":confirm1:confirm2" > } > ); > $t->post_ok( >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34212
:
153084
|
153145
|
153146
| 153147