Attachment 153186 Details for Bug 34199 – Bug 34199: Add full title information to subscription detail page

[patch] Bug 34199: Add full title information to subscription detail page

Bug-34199-Add-full-title-information-to-subscripti.patch (text/plain), 4.54 KB, created by Katrin Fischer on 2023-07-07 15:31:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-07-07 15:31:31 UTC

Size: 4.54 KB

patch

obsolete

>From 22d93eb77ce8ea437331cad70f67c859c5390497 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer@bsz-bw.de>
>Date: Fri, 7 Jul 2023 15:27:42 +0000
>Subject: [PATCH] Bug 34199: Add full title information to subscription detail
> page
>
>Show the full title information, including part_name and part_number
>on the subscription detail page.
>
>To test:
>* Add a subscription linked to a record with 245$abnp set
>* Verify only 245$ab will show up on the subscription detail page
>* Apply patch
>* Verify that the full title information shows up on the detail page
>---
> .../prog/en/modules/serials/subscription-detail.tt        | 8 ++++++--
> serials/subscription-detail.pl                            | 5 +++--
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>index 3d3d5a5052..e596aba702 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
>@@ -7,6 +7,7 @@
> [% USE Price %]
> [% USE TablesSettings %]
> [% SET footerjs = 1 %]
>+[%- PROCESS 'html_helpers.inc' -%]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Details for subscription #[% subscriptionid | html %] &rsaquo; Serials &rsaquo; Koha</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -42,7 +43,7 @@
>                 [% INCLUDE 'serials-toolbar.inc' %]
>                 [% INCLUDE 'mana/mana-comment-status.inc' %]
> 
>-                <h1>Subscription for [% bibliotitle | html %] [% bibliosubtitle | html %] [% IF closed %](closed)[% END %]</h1>
>+                <h1>Subscription for [% INCLUDE 'biblio-title.inc' biblio=subscription.biblio link = 0 %] [% IF closed %](closed)[% END %]</h1>
> 
>                 [% IF ( abouttoexpire ) %]
>                     [% UNLESS closed %]
>@@ -102,7 +103,10 @@
>                                             <li><span class="label">Subscription ID: </span>[% subscriptionid | html %]</li>
>                                             <li><span class="label">Librarian identity:</span> [% librarian | html %]</li>
>                                             <li><span class="label">Vendor:</span> <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% aqbooksellerid | uri %]">[% aqbooksellername | html %]</a></li>
>-                                            <li><span class="label">Biblio:</span>  <a href="[% PROCESS biblio_a_href biblionumber => bibnum %]">[% bibliotitle | html %] [% bibliosubtitle | html %]</a> <em>([% bibnum | html %])</em></li>
>+                                            <li>
>+                                                <span class="label">Bibliographic record:</span>
>+                                                [%- INCLUDE 'biblio-title.inc' biblio=subscription.biblio link = 1 -%] <em>([% subscription.biblionumber | html %])</em>
>+                                            </li>
>                                             [% IF ( OPACBaseURL ) %]
>                                                 <li>
>                                                     <span class="label">OPAC view:</span>
>diff --git a/serials/subscription-detail.pl b/serials/subscription-detail.pl
>index 2ae5cd3ef7..23c57dd7ca 100755
>--- a/serials/subscription-detail.pl
>+++ b/serials/subscription-detail.pl
>@@ -38,6 +38,7 @@ my $op = $query->param('op') || q{};
> my $issueconfirmed = $query->param('issueconfirmed');
> my $dbh = C4::Context->dbh;
> my $subscriptionid = $query->param('subscriptionid');
>+my $subscription = Koha::Subscriptions->find( $subscriptionid );
> 
> if ( $op and $op eq "close" ) {
>     C4::Serials::CloseSubscription( $subscriptionid );
>@@ -124,12 +125,11 @@ my @irregular_issues = split /;/, $subs->{irregularity};
> my $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($subs->{periodicity});
> my $numberpattern = C4::Serials::Numberpattern::GetSubscriptionNumberpattern($subs->{numberpattern});
> 
>-my $subscription_object = Koha::Subscriptions->find( $subscriptionid );
> $template->param(
>     available_additional_fields => Koha::AdditionalFields->search( { tablename => 'subscription' } ),
>     additional_field_values => {
>         map { $_->field->name => $_->value }
>-          $subscription_object->additional_field_values->as_list
>+          $subscription->additional_field_values->as_list
>     },
> );
> 
>@@ -151,6 +151,7 @@ while ( my $o = $orders->next ) {
> }
> 
> $template->param(
>+    subscription => $subscription,
>     subscriptionid => $subscriptionid,
>     serialslist => \@serialslist,
>     hasRouting  => $hasRouting,
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34199: 153186 | 153187 | 156015