Attachment 153210 Details for Bug 34184 – Bug 34184: Add empty option for suggestion "document type"

[patch] Bug 34184: Add empty option for suggestion "document type"

Bug-34184-Add-empty-option-for-suggestion-document.patch (text/plain), 1.72 KB, created by Katrin Fischer on 2023-07-09 12:53:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-07-09 12:53:59 UTC

Size: 1.72 KB

patch

obsolete

>From bb74da853363031152ffd1ca8ca23ea4732e1a45 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 5 Jul 2023 12:41:09 +0200
>Subject: [PATCH] Bug 34184: Add empty option for suggestion "document type"
>
>Currently when editing a suggestion, the document type will preselect to the
>first entry as we don't have an empty entry.
>This can lead to data errors easily.
>
>Test plan:
>Create a new suggestion
>=> Notice that "document type" is empty by default, pick one
>Edit it again
>=> Notice that the value is kept and empty can be picked, pick empty
>Edit again
>=> Empty is selected and saved in DB
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt      | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index b1b442d79c..20c542aa88 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -380,7 +380,7 @@
>                         </li>
>                         <li>
>                             <label for="itemtype">Document type:</label>
>-                            [% PROCESS 'av-build-dropbox.inc' name="itemtype", category="SUGGEST_FORMAT", size = 20, default=itemtype %]
>+                            [% PROCESS 'av-build-dropbox.inc' name="itemtype", category="SUGGEST_FORMAT", size=20, default=itemtype, empty=1 %]
>                         </li>
>                         [% IF patron_reason_loop %]
>                             <li>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34184: 153050 | 153054 | 153210