Bugzilla – Attachment 153222 Details for
Bug 34225
KohaTable broken on batch item deletion and modification results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34225: KohaTable broken on batch item deletion and modification results
Bug-34225-KohaTable-broken-on-batch-item-deletion-.patch (text/plain), 2.91 KB, created by
Katrin Fischer
on 2023-07-09 14:18:40 UTC
(
hide
)
Description:
Bug 34225: KohaTable broken on batch item deletion and modification results
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-07-09 14:18:40 UTC
Size:
2.91 KB
patch
obsolete
>From 61598e6c9a9f765f37172771e4e7ba39b7b2ed2a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 7 Jul 2023 12:19:27 +0000 >Subject: [PATCH] Bug 34225: KohaTable broken on batch item deletion and > modification results > >This patch adds the columns_settings include file to the batch item >modification and batch item deletion templates so that the tables can be >rendered as DataTables. > >To test, apply the patch and go to Cataloging -> Batch item >modification. > >- Submit a batch of barcodes or item numbers for modification. >- On the next page which shows all the items you submitted, the table > should be rendered as a DataTable. >- Confirm that sorting, filtering, and export all work correctly. >- Confirm that there are not JS errors in the browser console. >- Perform the same tests on Cataloging -> Batch item deletion. > >Signed-off-by: Sam Lau <samalau@gmail.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 1 + > koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js | 2 +- > 3 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >index 79908a3a0b..1608d37c64 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >@@ -189,6 +189,7 @@ > [% MACRO jsinclude BLOCK %] > [% Asset.js("js/tools-menu.js") | $raw %] > [% INCLUDE 'datatables.inc' %] >+ [% INCLUDE 'columns_settings.inc' %] > [% Asset.js("js/pages/batchMod.js") | $raw %] > [% Asset.js("js/browser.js") | $raw %] > <script> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >index 696467bba2..580c8b12df 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >@@ -235,6 +235,7 @@ > [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %] > [% Asset.js("js/cataloging.js") | $raw %] > [% INCLUDE 'datatables.inc' %] >+ [% INCLUDE 'columns_settings.inc' %] > [% Asset.js("js/pages/batchMod.js") | $raw %] > [% INCLUDE 'select2.inc' %] > [% INCLUDE 'calendar.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js b/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js >index f8fe139ccf..4118c6b013 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/batchMod.js >@@ -1,4 +1,4 @@ >-/* global dataTablesDefaults allColumns Cookies */ >+/* global KohaTable allColumns Cookies */ > // Set expiration date for cookies > var date = new Date(); > date.setTime(date.getTime() + (365 * 24 * 60 * 60 * 1000)); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34225
:
153171
|
153190
| 153222