Attachment 153284 Details for Bug 34228 – Bug 34228: Add translation context to "Managed by"

[patch] Bug 34228: Add translation context to "Managed by"

Bug-34228-Add-translation-context-to-Managed-by.patch (text/plain), 5.66 KB, created by Lucas Gass (lukeg) on 2023-07-10 15:25:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-07-10 15:25:42 UTC

Size: 5.66 KB

patch

obsolete

>From f9fdb8692ed518ecbd7a45c78bd3e9b4104be227 Mon Sep 17 00:00:00 2001
>From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>Date: Mon, 10 Jul 2023 10:52:35 -0400
>Subject: [PATCH] Bug 34228: Add translation context to "Managed by"
>
>This patch adds context for translators to the Managed by string when it
>applies to acquisitions baskets (as opposed to purchase suggestions).
>
>To test:
>0. If you don't already have acquisitions set up, create a budget and a vendor
>
>1. Apply patch
>
>2. Create a basket
>   2.1. Go to Acquisitions
>   2.2. Search for a vendor
>   2.3. Click New > Basket
>   2.4. Fill out the form
>   2.5. Click Save
>
>3. View the basket details page
>   --> The page works (no errors)
>   --> 'Managed by:' is displayed on the right, no spelling errors
>
>4. Click Add to basket > From a new (empty) record
>   --> The page works (no errors)
>   --> 'Managed by:' is displayed under Basket details, no spelling errors
>
>5. Click Cancel
>
>6. Update the po files
>
>gulp po:update --lang xx-XX
>
>for example, gulp po:update --lang fr-CA
>
>7. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po)
>   --> There should be an entry for 'Managed by:' with a line msgctxt that gives the 'Acquisitions basket managed by user' context
>
>8. Update the file with a random phrase for the 'Managed by:' translation
>
>for example, I translated 'Managed by:' by 'AAAAAAA:', just to see the difference
>
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt:308
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt:281
>msgctxt "Acquisitions basket managed by user"
>msgid "Managed by:"
>msgstr "AAAAAAA:"
>
>9. Install a new language
>   9.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA)
>
>   ./misc/translator/translate install xx-XX
>
>   9.2. In the Koha staff interface, go to Administration > System preferences
>   9.3. Search for language
>   9.4. Check the box next to the new language
>   9.5. Save
>
>10. Switch the language of the interface
>
>11. Redo steps 3 and 4
>   --> The pages still work (no errors)
>   --> The 'Managed by:' string should be replaced by whatever you put in step 8
>
>Optional test
>12. In the staff interface in English, view one or more of these pages, the 'Managed by' string should be unchanged
>- Acquisitions > Suggestions (Managed by column heading)
>- Acquisitions > Suggestions (Organize by: Managed by sorting option)
>- Acquisitions > Suggestions (Filter by: Suggestion information: Managed by filter option)
>- Acquisitions > Suggestions > Click on a suggestion (Managed by table row under Suggestion management)
>- Patrons > Patron account > Purchase suggestions (Managed by column heading)
>
>13. View these same pages in the other language, the Managed by string should NOT be changed to whatever you put in step 8
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt        | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 5cd5d7b1b1..11200a8110 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -305,7 +305,7 @@
>                                                     <ol>
>                                                         <li id="managedby">
>                                                             <form action="/cgi-bin/koha/acqui/basket.pl" method="post">
>-                                                                <span class="label">Managed by:</span>
>+                                                                <span class="label">[% tp('Acquisitions basket managed by user', 'Managed by:') | html %]</span>
>                                                                 <div style="display:inline-block">
>                                                                     <ul id="users_names" style="padding-left:0">
>                                                                         [% FOREACH user IN users %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>index 42f537a592..ba9d782acb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>@@ -5,6 +5,7 @@
> [% USE Price %]
> [% USE ItemTypes %]
> [% USE AuthorisedValues %]
>+[% PROCESS 'i18n.inc' %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>[% IF ( ordernumber ) %]Modify order details (line #[% ordernumber | html %])[% ELSE %]New order[% END %] &rsaquo; Basket [% basketno | html %] &rsaquo; Acquisitions &rsaquo; Koha</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -277,7 +278,7 @@
>             <li><span class="label">Contract number: </span>[% basketcontractno | html %]</li>
>             <li><span class="label">Contract name:</span> <a href="/cgi-bin/koha/admin/aqcontract.pl?op=add_form&amp;contractnumber=[% basketcontractno | uri %]">[% basketcontractname | html %]</a></li>
>         [% END %]
>-        [% IF ( authorisedbyname ) %]<li><span class="label">Managed by:</span>  [% authorisedbyname | html %]</li>[% END %]
>+        [% IF ( authorisedbyname ) %]<li><span class="label">[% tp('Acquisitions basket managed by user', 'Managed by:') | html %]</span>  [% authorisedbyname | html %]</li>[% END %]
>         [% IF ( creationdate ) %]<li><span class="label">Open on:</span>  [% creationdate | $KohaDates %]</li>[% END %]
>         [% IF ( closedate ) %]
>         <form action="/cgi-bin/koha/acqui/basketgroup.pl" method="post">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34228: 153282 | 153284 | 155655