Bugzilla – Attachment 153299 Details for
Bug 33946
biblio-title.inc should not add a link if biblio does not exist
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33946: (QA follow-up) Add spans and classes for styling and translatability
Bug-33946-QA-follow-up-Add-spans-and-classes-for-s.patch (text/plain), 1.87 KB, created by
Katrin Fischer
on 2023-07-10 21:10:27 UTC
(
hide
)
Description:
Bug 33946: (QA follow-up) Add spans and classes for styling and translatability
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-07-10 21:10:27 UTC
Size:
1.87 KB
patch
obsolete
>From e3b5ebc8d93d537eeb82ebc672b2bab3bc75011a Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 10 Jul 2023 21:08:38 +0000 >Subject: [PATCH] Bug 33946: (QA follow-up) Add spans and classes for styling > and translatability > >Adds back the spans around No title and more spans for >'No bibliographic record' with individual classes for each >to allow for styling later. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/biblio-title.inc | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-title.inc >index 7ef94166b4..66ebc8527a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-title.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-title.inc >@@ -4,9 +4,9 @@ > [%- END -%] > > [%- IF !biblio -%] >- No bibliographic record >+ <span class="biblio-no-record">No bibliographic record</span> > [%- ELSIF !biblio.title -%] >- No title >+ <span class="biblio-no-title">No title</span> > [%- ELSE -%] > <span class="biblio-title">[% biblio.title | html %]</span> > [%- END -%] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc >index 7201dd2df8..679fde6b72 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc >@@ -4,9 +4,9 @@ > [%- END -%] > > [%- IF !biblio -%] >- No bibliographic record >+ <span class="biblio-no-record">No bibliographic record</span> > [%- ELSIF !biblio.title -%] >- No title >+ <span class="biblio-no-title">No title</span> > [%- ELSE -%] > <span class="biblio-title">[% biblio.title | html %]</span> > [%- END -%] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33946
:
152145
|
152178
|
152179
|
153297
|
153298
| 153299