Attachment 153301 Details for Bug 31736 – Bug 31736: Context for translation: 'All' (All libraries)

[patch] Bug 31736: Context for translation: 'All' (All libraries)

Bug-31736-Context-for-translation-All-All-librarie.patch (text/plain), 12.01 KB, created by Caroline Cyr La Rose on 2023-07-10 21:20:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caroline Cyr La Rose

Created: 2023-07-10 21:20:29 UTC

Size: 12.01 KB

patch

obsolete

>From aa82a487a18216493bba7334100b29ed472c2f38 Mon Sep 17 00:00:00 2001
>From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>Date: Mon, 10 Jul 2023 16:52:40 -0400
>Subject: [PATCH] Bug 31736: Context for translation: 'All' (All libraries)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch adds context for translators for the term 'All' when it refers to 'All libraries'.
>
>1. Apply patch
>
>2. View the following pages
>   --> The pages work (no errors)
>   --> No spelling errors in 'All' libraries
>
>   - Acquisitions > Invoices (Library filter on the left)
>   - Circulation > Holds queue (Library filter)
>   - Reports > Cash register (Transaction library filter)
>   - Reports > Items lost (Library filter)
>   - Serials > Check expiration (Library filter)
>   - Serials > Search settings icon in the search bar > Advanced search (Library filter)
>   - Acquisitions > Add to basket > From a subscription (Library filter on the left)
>   - Installer > Onboarding > New circulation rule (Library)
>
>3. Update the po files
>
>   gulp po:update --lang xx-XX
>
>   for example, gulp po:update --lang fr-CA
>
>4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po)
>   --> There should be an entry for 'All' with a line msgctxt that gives the 'All libraries/branches' context
>
>5. Update the file with a random word or phrase for the 'All' translation
>
>For example, I translated 'All' by 'Toutes les bibliothÃ¨ques'
>
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:383
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt:254
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:64
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt:115
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt:146
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt:48
>\#: koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc:41
>\#: koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc:34
>msgctxt "All libraries/branches"
>msgid "All"
>msgstr "Toutes les bibliothÃ¨ques"
>
>6. Install a new language
>   6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA)
>
>   ./misc/translator/translate install xx-XX
>
>   6.2. In the Koha staff interface, go to Administration > System preferences
>   6.3. Search for language
>   6.4. Check the box next to the new language
>   6.5. Save
>
>7. Switch the language of the interface
>
>8. Redo step 2
>   --> The pages still work (no errors)
>   --> The 'All' libraries string should be replaced by whatever you put in step 5
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc | 3 ++-
> .../intranet-tmpl/prog/en/includes/subscriptions-search.inc    | 3 ++-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt      | 3 ++-
> .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt      | 3 ++-
> .../prog/en/modules/onboarding/onboardingstep5.tt              | 3 ++-
> .../prog/en/modules/reports/cash_register_stats.tt             | 3 ++-
> koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt   | 3 ++-
> .../intranet-tmpl/prog/en/modules/serials/checkexpiration.tt   | 3 ++-
> 8 files changed, 16 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc
>index ec34b6f073..757ee265fa 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-advsearch.inc
>@@ -1,3 +1,4 @@
>+[% PROCESS 'i18n.inc' %]
> [% PROCESS 'html_helpers.inc' %]
> <div id="advsearch" style="padding-bottom:3em;">
>     <form action="/cgi-bin/koha/serials/serials-search.pl" method="get">
>@@ -37,7 +38,7 @@
>                 <li class="local">
>                     <label for="branch">Library:</label>
>                     <select id="branch" name="branch_filter">
>-                        <option value="">All</option>
>+                        <option value="">[% tp('All libraries/branches', 'All') | html %]</option>
>                         [%# FIXME Should not we filter the libraries? %]
>                         [% PROCESS options_for_libraries libraries => Branches.all( selected => branch_filter, unfiltered => 1 ) %]
>                     </select>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
>index 5e1275d249..ff8707323f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
>@@ -1,3 +1,4 @@
>+[% PROCESS 'i18n.inc' %]
> [% PROCESS 'html_helpers.inc' %]
> <div id="advsearch">
>     <form action="" method="get">
>@@ -30,7 +31,7 @@
>               <li>
>                 <label for="branch">Library:</label>
>                 <select id="branch" name="branch_filter">
>-                  <option value="">All</option>
>+                  <option value="">[% tp('All libraries/branches', 'All') | html %]</option>
>                   [%# FIXME Should not we filter the libraries? %]
>                   [% PROCESS options_for_libraries libraries => Branches.all( selected => branch_filter, unfiltered => 1 ) %]
>                 </select>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>index 91cc429b7e..21f8651d01 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
>@@ -3,6 +3,7 @@
> [% USE AuthorisedValues %]
> [% USE KohaDates %]
> [% USE Branches %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Invoices &rsaquo; Acquisitions &rsaquo; Koha</title>
>@@ -379,7 +380,7 @@
>                             <li>
>                                 <label for="branch">Library:</label>
>                                 <select id="branch" name="branch">
>-                                    <option value="">All</option>
>+                                    <option value="">[% tp('All libraries/branches', 'All') | html %]</option>
>                                     [%# FIXME Should not we filter the libraries %]
>                                     [% PROCESS options_for_libraries libraries => Branches.all( selected => branch, unfiltered => 1 ) %]
>                                 </select>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>index fb87fa514b..66f2c93399 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>@@ -8,6 +8,7 @@
> [% USE TablesSettings %]
> [% USE Koha %]
> [% SET footerjs = 1 %]
>+[% PROCESS 'i18n.inc' %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Holds queue &rsaquo; Circulation &rsaquo; Koha</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -250,7 +251,7 @@
>                     <label for="branchlimit">Library: </label>
>                     <select name="branchlimit" id="branchlimit">
>                         [% IF CAN_user_superlibrarian || !Koha.Preference('IndependentBranches') %]
>-                            <option value="">All</option>
>+                            <option value="">[% tp('All libraries/branches', 'All') | html %]</option>
>                         [% END %]
>                         [% PROCESS options_for_libraries libraries => Branches.all( selected => branchlimit, only_from_group => 1 ) %]
>                     </select>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
>index 9daf2d73c9..dc40fd09a3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
>@@ -1,3 +1,4 @@
>+[% PROCESS 'i18n.inc' %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>
>     [% IF all_done %]
>@@ -60,7 +61,7 @@
>                                     <label for="branchname" class="required"> Library branch</label>
>                                     <select name="branch" id="branchname" required="required">
>                                         <option value=""> Choose</option>
>-                                        <option value="*" selected="selected">All</option>
>+                                        <option value="*" selected="selected">[% tp('All libraries/branches', 'All') | html %]</option>
>                                         [% FOREACH library IN libraries %]
>                                             <option value="[% library.branchcode | html %]"> [% library.branchname | html %]</option>
>                                         [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
>index b785a1ab82..4f8d369679 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
>@@ -8,6 +8,7 @@
> [% USE Registers %]
> [% SET footerjs = 1 %]
> [% PROCESS 'accounts.inc' %]
>+[% PROCESS 'i18n.inc' %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>[% IF ( do_it ) %]Cash register statistics &rsaquo; Results[% ELSE %]Cash register statistics[% END %] &rsaquo; Reports &rsaquo; Koha</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -111,7 +112,7 @@
>                 <li>
>                     <label>Transaction library</label>
>                     <select name="branch" id="branch">
>-                        <option value="ALL">All</option>
>+                        <option value="ALL">[% tp('All libraries/branches', 'All') | html %]</option>
>                         [% FOREACH branchloo IN branchloop %]
>                             [% IF ( branchloo.selected ) %]
>                             <option value="[% branchloo.branchcode | html %]" selected="selected">[% branchloo.branchname | html %]</option>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
>index 0be4a3ba7c..512d1ad158 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
>@@ -6,6 +6,7 @@
> [% USE KohaDates %]
> [% USE ItemTypes %]
> [% USE Price %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Lost items &rsaquo; Reports &rsaquo; Koha</title>
>@@ -142,7 +143,7 @@
> 
> 	<li><label for="barcodefilter">Barcode: </label><input type="text" name="barcodefilter" id="barcodefilter" size="6" /></li>
> 	<li><label for="branchfilter">Library: </label><select name="branchfilter" id="branchfilter">
>-                <option value="">All</option>
>+                <option value="">[% tp('All libraries/branches', 'All') | html %]</option>
>                 [% PROCESS options_for_libraries libraries => Branches.all() %]
>             </select></li>
>     <li><label for="itemtypesfilter">Item type: </label><select name="itemtypesfilter" id="itemtypesfilter">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>index abc04aa4c2..b83e001447 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
>@@ -1,6 +1,7 @@
> [% USE raw %]
> [% USE Branches %]
> [% USE KohaDates %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Check expiration &rsaquo; Serials &rsaquo; Koha</title>
>@@ -44,7 +45,7 @@
>         [% IF can_change_library %]
>         <li><label for="branch">Library:</label>
>         <select id="branch" name="branch">
>-            <option value="">All</option>
>+            <option value="">[% tp('All libraries/branches', 'All') | html %]</option>
>             [% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %]
>         </select>
>         </li>
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 31736: 153301 | 153302 | 162545 | 163817 | 163859 | 163860 | 163861 | 163862 | 163863 | 163864 | 163865 | 163866 | 163867 | 163868 | 163869 | 163870 | 163871 | 169498 | 170072 | 170281 | 170282 | 170283 | 170284 | 170285 | 170286 | 170287 | 170288 | 170289 | 170290 | 170291 | 170292 | 170293