Attachment 153302 Details for Bug 31736 – Bug 31736: Context for translation: 'All' (All patron categories)

[patch] Bug 31736: Context for translation: 'All' (All patron categories)

Bug-31736-Context-for-translation-All-All-patron-c.patch (text/plain), 8.34 KB, created by Caroline Cyr La Rose on 2023-07-10 21:20:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caroline Cyr La Rose

Created: 2023-07-10 21:20:30 UTC

Size: 8.34 KB

patch

obsolete

>From 15889645211c2899dfd5fadf7ba9cdfe576483b9 Mon Sep 17 00:00:00 2001
>From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>Date: Mon, 10 Jul 2023 17:04:57 -0400
>Subject: [PATCH] Bug 31736: Context for translation: 'All' (All patron
> categories)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch adds context for translators for the term 'All' when it refers to 'All patron categories'.
>
>1. Apply patch
>2. View the following pages
>   --> The pages work (no errors)
>   --> No spelling errors in 'All' patron categories
>
>   - Administration > Circulation and fines rules > Patron category column (All in existing rule)
>   - Administration > Circulation and fines rules > Patron category column (All in drop-down to create a new rule)
>   - Administration > Circulation and fines rules > Default waiting hold cancellation policy > Patron category column (All in existing rule)
>   - Administration > Circulation and fines rules > Default waiting hold cancellation policy > Patron category column (All in drop-down to create a new rule)
>   - Administration > Circulation and fines rules > Default article request fees > Patron category column (All in existing rule)
>   - Administration > Circulation and fines rules > Default article request fees > Patron category column (All in drop-down to create a new rule)
>   - Installer > Onboarding > New circulation rule (Patron category)
>
>3. Update the po files
>
>   gulp po:update --lang xx-XX
>
>   for example, gulp po:update --lang fr-CA
>
>4. Check the xx-XX-messages.po file (e.g. misc/translator/po/fr-CA-messages.po)
>   --> There should be an entry for 'All' with a line msgctxt that gives the 'All patron categories' context
>
>5. Update the file with a random word or phrase for the 'All' translation
>
>For example, I translated 'All' by "Toutes les catÃ©gories d'utilisateurs"
>
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:215
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:406
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:892
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:921
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:1027
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:1048
>\#: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt:75
>msgctxt "All patron categories"
>msgid "All"
>msgstr "Toutes les catÃ©gories d'utilisateurs"
>
>6. Install a new language
>   6.1. Run the following commands in the terminal, replacing xx-XX with the language code (e.g. fr-CA)
>
>   ./misc/translator/translate install xx-XX
>
>   6.2. In the Koha staff interface, go to Administration > System preferences
>   6.3. Search for language
>   6.4. Check the box next to the new language
>   6.5. Save
>
>7. Switch the language of the interface
>
>8. Redo step 2
>   --> The pages still work (no errors)
>   --> The 'All' patron categories string should be replaced by whatever you put in step 5
>---
> .../prog/en/modules/admin/smart-rules.tt            | 13 +++++++------
> .../prog/en/modules/onboarding/onboardingstep5.tt   |  2 +-
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index eb6a60b362..605156e8ec 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -7,6 +7,7 @@
> [% USE ItemTypes %]
> [% USE CirculationRules %]
> [% USE Price %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> 
> [% SET branchcode = humanbranch || undef %]
>@@ -211,7 +212,7 @@
>                                                     [% END %]</td>
>                                                 <td>
>                                                     [% IF c == undef %]
>-                                                        <em>All</em>
>+                                                        <em>[% tp('All patron categories', 'All') | html %]</em>
>                                                     [% ELSE %]
>                                                         [% Categories.GetName(c) | html %]
>                                                     [% END %]
>@@ -402,7 +403,7 @@
>                                 <td>2</td>
>                                 <td>
>                                     <select name="categorycode" id="categorycode">
>-                                        <option value="*">All</option>
>+                                        <option value="*">[% tp('All patron categories', 'All') | html %]</option>
>                                     [% FOREACH patron_category IN patron_categories%]
>                                         <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option>
>                                     [% END %]
>@@ -888,7 +889,7 @@
>                                         <tr>
>                                             <td>
>                                                 [% IF c == '*' %]
>-                                                    <em>All</em>
>+                                                    <em>[% tp('All patron categories', 'All') | html %]</em>
>                                                 [% ELSE %]
>                                                     [% Categories.GetName(c) | html %]
>                                                 [% END %]
>@@ -917,7 +918,7 @@
>                             <tr>
>                                 <td>
>                                     <select name="waiting_hold_cancellation_category" id="waiting_hold_cancellation_category">
>-                                        <option value="*">All</option>
>+                                        <option value="*">[% tp('All patron categories', 'All') | html %]</option>
>                                     [% FOREACH patron_category IN patron_categories %]
>                                         <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option>
>                                     [% END %]
>@@ -1023,7 +1024,7 @@
>                                 <tr>
>                                     <td>
>                                         [% IF c == '*' %]
>-                                            <em>All</em>
>+                                            <em>[% tp('All patron categories', 'All') | html %]</em>
>                                         [% ELSE %]
>                                             [% Categories.GetName(c) | html %]
>                                         [% END %]
>@@ -1044,7 +1045,7 @@
>                             <tr>
>                                 <td>
>                                     <select name="article_request_fee_category" id="article_request_fee_category">
>-                                        <option value="*">All</option>
>+                                        <option value="*">[% tp('All patron categories', 'All') | html %]</option>
>                                     [% FOREACH patron_category IN patron_categories%]
>                                         <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option>
>                                     [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
>index dc40fd09a3..9a1ab359f9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
>@@ -72,7 +72,7 @@
>                                     <label for="categorycode" class="required">Patron category: </label>
>                                     <select name="categorycode" id="categorycode" required="required">
>                                         <option value=""> Choose</option>
>-                                        <option value="*" selected="selected">All</option>
>+                                        <option value="*" selected="selected">[% tp('All patron categories', 'All') | html %]</option>
>                                         [% FOREACH category IN categories %]
>                                             <option value = "[% category.categorycode | html %]"> [% category.description | html %]</option>
>                                         [%END%]
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 31736: 153301 | 153302 | 162545 | 163817 | 163859 | 163860 | 163861 | 163862 | 163863 | 163864 | 163865 | 163866 | 163867 | 163868 | 163869 | 163870 | 163871 | 169498 | 170072 | 170281 | 170282 | 170283 | 170284 | 170285 | 170286 | 170287 | 170288 | 170289 | 170290 | 170291 | 170292 | 170293