Attachment 153303 Details for Bug 34220 – Bug 34220: Only show biblio-view-menu.inc if their is an associated bib

[patch] Bug 34220: Only show biblio-view-menu.inc if their is an associated bib

Bug-34220-Only-show-biblio-view-menuinc-if-their-i.patch (text/plain), 1.76 KB, created by Katrin Fischer on 2023-07-10 21:22:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-07-10 21:22:57 UTC

Size: 1.76 KB

patch

obsolete

>From 383842e7b9659404e23cc805dbab7baf41306b11 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 7 Jul 2023 23:12:56 +0000
>Subject: [PATCH] Bug 34220: Only show biblio-view-menu.inc if their is an
> associated bib
>
>To test:
>- Go to Tools > Log viewer
>- Uncheck All modules
>- Check the 'Catalog' module
>- Make sure "To screen in the browser" is the selected output
>- Click Submit
>
>After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber.
>
>-Apply patch
>-Try again, you should not see the biblio-view-menu
>-Try one more time but this time add a valid biblionumber to the Object: field. Now the biblio-view-menu should show with links to that particular bib.
>
>Works as advertised.
>Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>index 234c2d9502..c840d16fcc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>@@ -430,7 +430,7 @@
>                 [% IF ( circulation ) %]
>                     [% INCLUDE 'circ-menu.inc' %]
>                 [% ELSE %]
>-                    [% IF ( CATALOGUING ) %]
>+                    [% IF ( CATALOGUING && object ) %]
>                         [% INCLUDE 'biblio-view-menu.inc' %]
>                     [% ELSE %]
>                         [% INCLUDE 'tools-menu.inc' %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34220: 153206 | 153262 | 153303