Attachment 153308 Details for Bug 33581 – Bug 33581: Add sample patrons to patch and some hints

[patch] Bug 33581: Add sample patrons to patch and some hints

Bug-33581-Add-sample-patrons-to-patch-and-some-hin.patch (text/plain), 2.78 KB, created by Martin Renvoize (ashimema) on 2023-07-11 10:15:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-07-11 10:15:36 UTC

Size: 2.78 KB

patch

obsolete

>From dc303ffcb13d79482a9e990e56ab5bd5226964bf Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 8 Jun 2023 10:20:02 +0000
>Subject: [PATCH] Bug 33581: Add sample patrons to patch and some hints
>
>* Adds sample patrons to the new dependency checking JS
>* Adds a hind "requires sample libraries" to sample patrons
>  and sample holidays.
>
>To test:
>* Build CSS (yarn build)
>* Veriy the checkbox for sample patrons works like the
>  sample holidays one
>* Verify the hint shows up as intended
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/css/src/installer.scss    |  5 +++++
> .../intranet-tmpl/prog/en/modules/installer/step3.tt   | 10 ++++++----
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/installer.scss b/koha-tmpl/intranet-tmpl/prog/css/src/installer.scss
>index e823531d77..273183a3f0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/installer.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/installer.scss
>@@ -242,3 +242,8 @@ span.breadcrumbs {
> .complete {
>     color: green;
> }
>+
>+.hint {
>+    color: #727272;
>+    font-size: 90%;
>+}
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
>index 18d442093a..5a984edc96 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt
>@@ -463,14 +463,16 @@
>                     $( container ).find("input").prop("checked", state);
>                     $( container ).find(".selectall,.deselectall").toggle();
>                 });
>-                function update_sample_libraries_holidays(){
>+                let required_text = _("(requires sample libraries)");
>+                $("#sample_libraries_holidays, #sample_patrons").parent().after(" <span class='hint'>"+required_text+"</span>");
>+                function update_sample_libraries_dependencies(){
>                     let checked = $("#sample_libraries").prop("checked");
>-                    $("#sample_libraries_holidays").prop("disabled", !checked);
>+                    $("#sample_libraries_holidays, #sample_patrons").prop("disabled", !checked);
>                     if (!checked) {
>-                        $("#sample_libraries_holidays").prop("checked", false);
>+                        $("#sample_libraries_holidays, #sample_patrons").prop("checked", false);
>                     }
>                 };
>-                $("#sample_libraries").on("change", update_sample_libraries_holidays);
>+                $("#sample_libraries").on("change", update_sample_libraries_dependencies);
>                 $("#sample_libraries").change();
>             });
>         </script>
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 33581: 152083 | 152142 | 152143 | 152188 | 152189 | 153307 | 153308