Attachment 153325 Details for Bug 33270 – Bug 33270: (follow-up) Handle records that fail attempt to ignore bad characters

[patch] Bug 33270: (follow-up) Handle records that fail attempt to ignore bad characters

Bug-33270-follow-up-Handle-records-that-fail-attem.patch (text/plain), 2.26 KB, created by Nick Clemens (kidclamp) on 2023-07-11 14:00:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-07-11 14:00:18 UTC

Size: 2.26 KB

patch

obsolete

>From ff3a8da0ce72888f6cc2fd72ede468c9737a9297 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 11 Jul 2023 13:59:50 +0000
>Subject: [PATCH] Bug 33270: (follow-up) Handle records that fail attempt to
> ignore bad characters
>
>---
> Koha/OAI/Server/ListBase.pm       | 9 +++++++++
> koha-tmpl/opac-tmpl/xslt/OAI.xslt | 2 +-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/OAI/Server/ListBase.pm b/Koha/OAI/Server/ListBase.pm
>index 6fd2891050..0c4f3a8545 100644
>--- a/Koha/OAI/Server/ListBase.pm
>+++ b/Koha/OAI/Server/ListBase.pm
>@@ -170,6 +170,15 @@ sub GetRecords {
>                             %params
>                         )
>                     );
>+                } elsif ($marcxml_error) {
>+                    my $record = MARC::Record->new();
>+                    my $marcxml = $record->as_xml_record();
>+                    $self->record(
>+                        Koha::OAI::Server::Record->new(
>+                            $repository, $marcxml, $timestamp, \@setSpecs,
>+                            %params
>+                        )
>+                    );
>                 } else {
>                     $self->record(
>                         Koha::OAI::Server::DeletedRecord->new(
>diff --git a/koha-tmpl/opac-tmpl/xslt/OAI.xslt b/koha-tmpl/opac-tmpl/xslt/OAI.xslt
>index e81eda8a31..47125e24c0 100644
>--- a/koha-tmpl/opac-tmpl/xslt/OAI.xslt
>+++ b/koha-tmpl/opac-tmpl/xslt/OAI.xslt
>@@ -349,7 +349,7 @@
>                                             <span>
>                                                 <xsl:choose>
>                                                     <xsl:when test="text()='INVALID_METADATA'">
>-                                                        There was a problem decoding the metadata for this record, invalid characters were stripped. See system logs for details
>+                                                        There was a problem decoding the metadata for this record, an attempt was made to ignore invalid characters, the metadata view may be degraded. See system logs for details
>                                                     </xsl:when>
>                                                     <xsl:otherwise>
>                                                         <xsl:value-of select="text()" />
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33270: 152550 | 152573 | 152649 | 152650 | 152836 | 152837 | 153325 | 153542 | 153543 | 153544 | 153545 | 153546