Bugzilla – Attachment 153368 Details for
Bug 34243
Too many cities are created (at least in comments)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34243: Fix copy/pasted city references in api tests
Bug-34243-Fix-copypasted-city-references-in-api-te.patch (text/plain), 1.62 KB, created by
Marcel de Rooy
on 2023-07-12 14:55:45 UTC
(
hide
)
Description:
Bug 34243: Fix copy/pasted city references in api tests
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-07-12 14:55:45 UTC
Size:
1.62 KB
patch
obsolete
>From 220bc45581b7b5230675746fa641aed4e21e6476 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 12 Jul 2023 14:53:46 +0000 >Subject: [PATCH] Bug 34243: Fix copy/pasted city references in api tests >Content-Type: text/plain; charset=utf-8 > >Two occurrences. >Just comments. > >Test plan: >Read the patch. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/api/v1/smtp_servers.t | 2 +- > t/db_dependent/api/v1/suggestions.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/api/v1/smtp_servers.t b/t/db_dependent/api/v1/smtp_servers.t >index 79c6d59aa2..0852ddc062 100755 >--- a/t/db_dependent/api/v1/smtp_servers.t >+++ b/t/db_dependent/api/v1/smtp_servers.t >@@ -68,7 +68,7 @@ subtest 'list() tests' => sub { > my $smtp_server = > $builder->build_object( { class => 'Koha::SMTP::Servers' } ); > >- # One city created, should get returned >+ # One smtp server created, should get returned > $t->get_ok("//$userid:$password@/api/v1/config/smtp_servers") > ->status_is(200)->json_is( [ $smtp_server->to_api ] ); > >diff --git a/t/db_dependent/api/v1/suggestions.t b/t/db_dependent/api/v1/suggestions.t >index 9ad51e27bc..30e146516e 100755 >--- a/t/db_dependent/api/v1/suggestions.t >+++ b/t/db_dependent/api/v1/suggestions.t >@@ -72,7 +72,7 @@ subtest 'list() tests' => sub { > } > ); > >- # One city created, should get returned >+ # One suggestion created, should get returned > $t->get_ok("//$userid:$password@/api/v1/suggestions?q={\"suggested_by\":\"$patron_id\"}") > ->status_is(200)->json_is( [ $suggestion_1->to_api ] ); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34243
: 153368