Attachment 153385 Details for Bug 33052 – Bug 33052: Add a message for from_local_hold_group override

[patch] Bug 33052: Add a message for from_local_hold_group override

Bug-33052-Add-a-message-for-fromlocalholdgroup-ove.patch (text/plain), 1.54 KB, created by Emily Lamancusa (emlam) on 2023-07-12 19:06:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2023-07-12 19:06:49 UTC

Size: 1.54 KB

patch

obsolete

>From ed9696fd2265d0e94a94df8d21bada49e2a2b56c Mon Sep 17 00:00:00 2001
>From: Kyle Hall <kyle@bywatersolutions.com>
>Date: Thu, 23 Feb 2023 08:20:09 -0500
>Subject: [PATCH] Bug 33052: Add a message for from_local_hold_group override
>
>In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message.
>
>Test Plan:
>1) Overide a local group restricted hold, note there is no message
>2) Apply this patch
>3) Repeat step 1, note there is now a message!
>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index a3f9c2328a..98dee34483 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -1564,6 +1564,7 @@
>                 switch (override_items[itemnumber].holdallowed) {
>                     case "not_allowed": msg = _("This item normally cannot be put on hold."); break;
>                     case "from_home_library": msg = _("This item normally cannot be put on hold except for patrons from %s.").format(override_items[itemnumber].homebranch); break;
>+                    case "from_local_hold_group": msg = _("This item normally cannot be put on hold out its' local hold group."); break;
>                 }
> 
>                 msg += "\n\n" + _("Place hold on this item?");
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33052: 147231 | 153385 | 153386