Attachment 153387 Details for Bug 34261 – Bug 34261: Add missing argument to show_account

[patch] Bug 34261: Add missing argument to show_account

Bug-34261-Add-missing-argument-to-showaccount.patch (text/plain), 1.31 KB, created by Katrin Fischer on 2023-07-12 21:08:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-07-12 21:08:06 UTC

Size: 1.31 KB

patch

obsolete

>From 247366c324b92e0ea19b3b15290546de923abab4 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Wed, 12 Jul 2023 13:22:54 +0000
>Subject: [PATCH] Bug 34261: Add missing argument to show_account
>
>This patch fixes a missing $crypt in the show_account function when deleting an edifact ordering account.
>
>Test plan:
>1) In system preferences search for EDIFACT and change EDIFACT to Enable
>2) Navigate to Administration > EDI accounts
>3) Create a dummy account
>4) Try deleting the account using the delete button in the actions column on the far right
>5) An error should be thrown - "Can't call method "decrypt_hex" on an undefined value"
>6) Apply patch
>7) Try deleting the account again
>8) This time it should work and show the confirmation dialog box
>9) Sign off
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> admin/edi_accounts.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/edi_accounts.pl b/admin/edi_accounts.pl
>index 5394eaf351..65e3b4e1a2 100755
>--- a/admin/edi_accounts.pl
>+++ b/admin/edi_accounts.pl
>@@ -64,7 +64,7 @@ if ( $op eq 'acct_form' ) {
>     }
> }
> elsif ( $op eq 'delete_confirm' ) {
>-    show_account();
>+    show_account($crypt);
>     $template->param( delete_confirm => 1 );
> }
> else {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34261: 153360 | 153366 | 153387