Attachment 153388 Details for Bug 34209 – Bug 34209: Follow up on Bug 28726 - move whole 'select all ...' header into condition

[patch] Bug 34209: Follow up on Bug 28726 - move whole 'select all ...' header into condition

Bug-34209-Follow-up-on-Bug-28726---move-whole-sele.patch (text/plain), 2.20 KB, created by Katrin Fischer on 2023-07-12 21:16:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-07-12 21:16:20 UTC

Size: 2.20 KB

patch

obsolete

>From e5b28726429a166ca22306d09c2744367252d849 Mon Sep 17 00:00:00 2001
>From: Michael Hafen <michael.hafen@washk12.org>
>Date: Wed, 5 Jul 2023 11:17:09 -0600
>Subject: [PATCH] Bug 34209: Follow up on Bug 28726 - move whole 'select all
> ...' header into condition
>
>Move the whole search header div into the checkbox column condition, so
>that other patron search popups don't have an empty div.
>
>To test:
>* Activate the ERM module
>* Create a new agreement
>* Search for a user using the pop-up search
>* Verify there is an empty div showing as grey box above the table
>* Go to tools > label creator > new batch
>* Search for patrons
>* Verify the box isn't empty and shows the select all ... options
>* Apply patch
>* Repeat steps, verify the empty div is gone and the options remain
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt
>index 67f056ddb8..fe854bd58e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt
>@@ -21,18 +21,18 @@
>         </form>
> 
>         <div id="searchresults">
>+        [% IF columns.grep('checkbox').size %]
>             <div class="searchheader fh-fixedHeader" id="searchheader" style="display:none;">
>                 <div>
>-                [% IF columns.grep('checkbox').size %]
>                     <a href="#" class="btn btn-link" id="select_all"><i class="fa fa-check"></i> Select all</a>
>                     |
>                     <a href="#" class="btn btn-link" id="clear_all"><i class="fa fa-remove"></i> Clear all</a>
>                     [% IF selection_type == 'add' %]
>                     <button id="add-selected" class="btn btn-sm btn-default" type="submit">Add selected patrons</button>
>                     [% END %]
>-                [% END %]
>                 </div>
>             </div>
>+        [% END %]
>         [% PROCESS patron_search_table table_id => 'memberresultst' columns => columns %]
>         </div>
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34209: 153075 | 153350 | 153388