Bugzilla – Attachment 153467 Details for
Bug 30979
Add ability for OPAC users to checkout to themselves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30979: (follow-up) Fix public availability 500
Bug-30979-follow-up-Fix-public-availability-500.patch (text/plain), 1.26 KB, created by
Martin Renvoize (ashimema)
on 2023-07-14 11:29:33 UTC
(
hide
)
Description:
Bug 30979: (follow-up) Fix public availability 500
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-07-14 11:29:33 UTC
Size:
1.26 KB
patch
obsolete
>From a679380e2290a0e15b2998966edb265d131f04f6 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 17 May 2023 19:56:43 +0100 >Subject: [PATCH] Bug 30979: (follow-up) Fix public availability 500 > >When we introduced the logged in user id to the token generation we >had the knock on effect of creating a 500 response for unauthenticated >availability lookups. > >This patch resolves the 500, but results in a token that's not useful >for the end user. We should consider this in the wider context down the >line. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/REST/V1/Checkouts.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/REST/V1/Checkouts.pm b/Koha/REST/V1/Checkouts.pm >index 4c22f3570c..b3d02e012b 100644 >--- a/Koha/REST/V1/Checkouts.pm >+++ b/Koha/REST/V1/Checkouts.pm >@@ -161,7 +161,7 @@ sub get_availability { > $c->_check_availability( $patron, $item ); > > my $confirm_keys = join( ":", sort keys %{$confirmation} ); >- $confirm_keys = $user->id . ":" . $item->id . ":" . $confirm_keys; >+ $confirm_keys = $user ? $user->id : '' . ":" . $item->id . ":" . $confirm_keys; > my $token = Koha::Token->new->generate_jwt( { id => $confirm_keys } ); > > my $response = { >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30979
:
139131
|
139132
|
139133
|
139134
|
141274
|
141275
|
141276
|
141277
|
141278
|
141279
|
141300
|
145264
|
145265
|
145266
|
145267
|
145268
|
145277
|
145280
|
145281
|
145282
|
145283
|
145284
|
145285
|
145620
|
145621
|
145622
|
145623
|
145624
|
145625
|
145626
|
145627
|
145628
|
145629
|
145630
|
150867
|
150868
|
150869
|
150870
|
150871
|
150872
|
150873
|
150874
|
150875
|
150876
|
150877
|
150878
|
150879
|
150880
|
150881
|
150882
|
150883
|
150884
|
150885
|
150886
|
150887
|
150888
|
150889
|
150967
|
150968
|
150969
|
150970
|
150971
|
150972
|
150973
|
150974
|
151254
|
151255
|
151256
|
151257
|
151258
|
151259
|
151260
|
151261
|
151358
|
151359
|
151360
|
151361
|
151362
|
151363
|
151364
|
151365
|
151368
|
151369
|
151370
|
151371
|
151372
|
151373
|
151374
|
151375
|
151376
|
152789
|
152790
|
152791
|
152792
|
152793
|
152794
|
152795
|
152796
|
152797
|
153459
|
153460
|
153461
|
153462
|
153463
|
153464
|
153465
|
153466
| 153467 |
153500
|
153501
|
153502
|
153503