Bugzilla – Attachment 153472 Details for
Bug 34279
overduefinescap of 0 is ignored, but overduefinescap of 0.00 is enforced
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34279: Don't enforce overduefinescap unless it is greater than 0
Bug-34279-Dont-enforce-overduefinescap-unless-it-i.patch (text/plain), 1.07 KB, created by
Kyle M Hall (khall)
on 2023-07-14 11:37:10 UTC
(
hide
)
Description:
Bug 34279: Don't enforce overduefinescap unless it is greater than 0
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-07-14 11:37:10 UTC
Size:
1.07 KB
patch
obsolete
>From b4a4706655cb605eebb577c6350b1d864c2707d4 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 14 Jul 2023 07:36:47 -0400 >Subject: [PATCH] Bug 34279: Don't enforce overduefinescap unless it is greater > than 0 > >--- > C4/Overdues.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index 8074411a9a..41674a468a 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -282,7 +282,10 @@ sub CalcFine { > } > } # else { # a zero (or null) chargeperiod or negative units_minus_grace value means no charge. } > >- $amount = $issuing_rule->{overduefinescap} if $issuing_rule->{overduefinescap} && $amount > $issuing_rule->{overduefinescap}; >+ $amount = $issuing_rule->{overduefinescap} >+ if $issuing_rule->{overduefinescap} >+ && $issuing_rule->{overduefinescap} > 0 >+ && $amount > $issuing_rule->{overduefinescap}; > > # This must be moved to Koha::Item (see also similar code in C4::Accounts::chargelostitem > $item->{replacementprice} ||= $itemtype->defaultreplacecost >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34279
:
153471
|
153472
|
153475
|
153476
|
153483
|
153484
|
153485
|
153648
|
153649