Attachment 153496 Details for Bug 33808 – Bug 33808: Add aria-labels in opac-basket.tt

[patch] Bug 33808: Add aria-labels in opac-basket.tt

Bug-33808-Add-aria-labels-in-opac-baskettt.patch (text/plain), 1.87 KB, created by Kyle M Hall (khall) on 2023-07-14 18:01:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-07-14 18:01:59 UTC

Size: 1.87 KB

patch

obsolete

>From 82ff5c0dabdaa285984fdd148633f764338c63ba Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Tue, 23 May 2023 14:00:11 +0000
>Subject: [PATCH] Bug 33808: Add aria-labels in opac-basket.tt
>
>This patch adds an aria-label and an aria-haspopup to Download buttons
>identified as non-descriptive in accessibility testing
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>index 7b20dad9c3..30969b9013 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>@@ -31,7 +31,7 @@
>                                 [% END %]
> 
>                                 <div id="download-cart" class="btn-group dropdown">
>-                                    <a id="format" class="btn btn-link dropdown-toggle" data-toggle="dropdown" role="button" href="#"><i class="fa fa-fw fa-download" aria-hidden="true"></i> Download <b class="caret"></b></a>
>+                                    <a id="format" class="btn btn-link dropdown-toggle" aria-haspopup="menu" aria-label="Select format and download cart" data-toggle="dropdown" role="button" href="#"><i class="fa fa-fw fa-download" aria-hidden="true"></i> Download <b class="caret"></b></a>
>                                     <div class="dropdown-menu" role="menu" aria-labelledby="format">
>                                         <a role="menuitem" class="dropdown-item download-cart" data-format="bibtex" href="#">BibTeX</a>
>                                         <a role="menuitem" class="dropdown-item download-cart" data-format="isbd" href="#">ISBD</a>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33808: 151564 | 151565 | 151566 | 151567 | 151597 | 151598 | 151599 | 151617 | 151621 | 153495 | 153496 | 153497 | 153498