Attachment 153498 Details for Bug 33808 – Bug 33808: Add aria-labels in reports-toolbar.inc

[patch] Bug 33808: Add aria-labels in reports-toolbar.inc

Bug-33808-Add-aria-labels-in-reports-toolbarinc.patch (text/plain), 1.87 KB, created by Kyle M Hall (khall) on 2023-07-14 18:02:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-07-14 18:02:03 UTC

Size: 1.87 KB

patch

obsolete

>From 2cbac13e58212db2b10629a6bc08b57e68d17917 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Tue, 23 May 2023 14:01:40 +0000
>Subject: [PATCH] Bug 33808: Add aria-labels in reports-toolbar.inc
>
>This patch adds an aria-label and an aria-haspopup to Download buttons
>identified as non-descriptive in accessibility testing
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>index d4020047d7..ba5b9d3d92 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>@@ -112,7 +112,7 @@
> 
> 
>             <div class="btn-group">
>-                <button class="btn btn-default dropdown-toggle" data-toggle="dropdown" id="format"><i class="fa fa-download"></i> Download <span class="caret"></span></button>
>+                <button class="btn btn-default dropdown-toggle" aria-haspopup="menu" aria-label="Select format and download report results" data-toggle="dropdown" id="format"><i class="fa fa-download"></i> Download <span class="caret"></span></button>
>                 <ul class="dropdown-menu">
>                     <li><a id="csv" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&amp;format=csv&amp;report_id=[% id | html %]&amp;reportname=[% name |uri %][% PROCESS params %]">[% PROCESS 'delimiter_text.inc' %]</a></li>
>                     <li><a id="tab" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&amp;format=tab&amp;report_id=[% id | html %]&amp;reportname=[% name |uri %][% PROCESS params %]">Tab separated text</a></li>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33808: 151564 | 151565 | 151566 | 151567 | 151597 | 151598 | 151599 | 151617 | 151621 | 153495 | 153496 | 153497 | 153498