Attachment 153545 Details for Bug 33270 – Bug 33270: (QA follow-up) Tidy

[patch] Bug 33270: (QA follow-up) Tidy

Bug-33270-QA-follow-up-Tidy.patch (text/plain), 1.25 KB, created by Marcel de Rooy on 2023-07-17 13:11:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-07-17 13:11:55 UTC

Size: 1.25 KB

patch

obsolete

>From 6eac64138680c0ab68fd1081d7f3bf52e5c5f0c9 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 17 Jul 2023 10:52:03 +0000
>Subject: [PATCH] Bug 33270: (QA follow-up) Tidy
>Content-Type: text/plain; charset=utf-8
>
>Resolve:
>WARN   tidiness
>  The file is less tidy than before (bad/messy lines before: 21, now: 24)
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Biblio/Metadata.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Biblio/Metadata.pm b/Koha/Biblio/Metadata.pm
>index 474049f75e..448a08b70f 100644
>--- a/Koha/Biblio/Metadata.pm
>+++ b/Koha/Biblio/Metadata.pm
>@@ -148,7 +148,7 @@ Will return undef if the record cannot be built
> 
> sub record_strip_nonxml {
> 
>-    my ($self, $params) = @_;
>+    my ( $self, $params ) = @_;
> 
>     my $record;
>     my $marcxml_error;
>@@ -159,7 +159,7 @@ sub record_strip_nonxml {
>             $self->schema
>         );
>     };
>-    if( $@ ){
>+    if ($@) {
>         $marcxml_error = $@;
>         chomp $marcxml_error;
>         warn $marcxml_error;
>@@ -167,7 +167,7 @@ sub record_strip_nonxml {
>     }
> 
>     $params->{record} = $record;
>-    return $self->record( $params );
>+    return $self->record($params);
> }
> 
> =head2 Internal methods
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33270: 152550 | 152573 | 152649 | 152650 | 152836 | 152837 | 153325 | 153542 | 153543 | 153544 | 153545 | 153546