Bugzilla – Attachment 153590 Details for
Bug 34303
t/00-testcritic.t should only test files part of git repo
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34303: Loop over pl and pm from the git repo
Bug-34303-Loop-over-pl-and-pm-from-the-git-repo.patch (text/plain), 884 bytes, created by
Jonathan Druart
on 2023-07-18 12:07:31 UTC
(
hide
)
Description:
Bug 34303: Loop over pl and pm from the git repo
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-07-18 12:07:31 UTC
Size:
884 bytes
patch
obsolete
>From 4868e5eecbd2714042233093be65d2708ad63e6c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 Jul 2023 14:06:43 +0200 >Subject: [PATCH] Bug 34303: Loop over pl and pm from the git repo > >We don't want to include files that are not in the git index. >--- > t/00-testcritic.t | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/t/00-testcritic.t b/t/00-testcritic.t >index c60122e1d74..c384459f993 100755 >--- a/t/00-testcritic.t >+++ b/t/00-testcritic.t >@@ -14,5 +14,10 @@ if ( $EVAL_ERROR ) { > } > > Test::Perl::Critic->import( -profile => '.perlcriticrc'); >-my @dirs = `git ls-tree -d --name-only master`; >-all_critic_ok(@dirs) if @dirs; >+my @files = `git ls-tree -r HEAD --name-only | grep -E '.*\\.(pl|pm)'`; >+for my $file ( @files ) { >+ chomp $file; >+ critic_ok($file); >+} >+ >+done_testing(); >-- >2.25.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=153590">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34303
:
153588
|
153589
|
153590
|
153591
|
153592
|
153596