Attachment 153596 Details for Bug 34303 – Bug 34303: Only perlcritic files from git repo

[patch] Bug 34303: Only perlcritic files from git repo

Bug-34303-Only-perlcritic-files-from-git-repo.patch (text/plain), 976 bytes, created by Jonathan Druart on 2023-07-18 12:22:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-07-18 12:22:03 UTC

Size: 976 bytes

patch

obsolete

>From 323d3f386d18865226b6ff8de47173a6106a0d8f Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 18 Jul 2023 10:59:33 +0000
>Subject: [PATCH] Bug 34303: Only perlcritic files from git repo
>
>Test plan:
>Run t/00-testcritic.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>JD amended patch: tidy
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/00-testcritic.t | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/t/00-testcritic.t b/t/00-testcritic.t
>index cd3a7af71ba..debd8b2f18d 100755
>--- a/t/00-testcritic.t
>+++ b/t/00-testcritic.t
>@@ -13,5 +13,6 @@ if ( $EVAL_ERROR ) {
>     plan( skip_all => $msg );
> }
> 
>-Test::Perl::Critic->import( -profile => '.perlcriticrc');
>-all_critic_ok('.');
>+Test::Perl::Critic->import( -profile => '.perlcriticrc' );
>+my @files = map { chomp; $_ } `git ls-tree -r master --name-only`;    # only files part of git
>+all_critic_ok(@files);
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 34303: 153588 | 153589 | 153590 | 153591 | 153592 | 153596