Bugzilla – Attachment 153598 Details for
Bug 33444
AddRenewal should take a hash of parameters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33444: (QA follow-up) Tidy block in automatic_renewals.pl
Bug-33444-QA-follow-up-Tidy-block-in-automaticrene.patch (text/plain), 1.77 KB, created by
Marcel de Rooy
on 2023-07-18 12:32:47 UTC
(
hide
)
Description:
Bug 33444: (QA follow-up) Tidy block in automatic_renewals.pl
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-07-18 12:32:47 UTC
Size:
1.77 KB
patch
obsolete
>From edf44aad334558dfa75ba9c5c906474dfe649aae Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 18 Jul 2023 11:10:22 +0000 >Subject: [PATCH] Bug 33444: (QA follow-up) Tidy block in automatic_renewals.pl >Content-Type: text/plain; charset=utf-8 > >Resolves: >The file is less tidy than before (bad/messy lines before: 94, now: 101) > >Test plan: >Run qa tools. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > misc/cronjobs/automatic_renewals.pl | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > >diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl >index 4d82196ae2..4fa83566a8 100755 >--- a/misc/cronjobs/automatic_renewals.pl >+++ b/misc/cronjobs/automatic_renewals.pl >@@ -181,13 +181,15 @@ while ( my $auto_renew = $auto_renews->next ) { > $auto_renew->issue_id, $auto_renew->borrowernumber, $auto_renew->itemnumber, $confirm ? 'will' : 'would'; > } > if ($confirm){ >- my $date_due = AddRenewal({ >- borrowernumber => $auto_renew->borrowernumber, >- itemnumber => $auto_renew->itemnumber, >- branch => $auto_renew->branchcode, >- seen => 0, >- automatic => 1, >- }); >+ my $date_due = AddRenewal( >+ { >+ borrowernumber => $auto_renew->borrowernumber, >+ itemnumber => $auto_renew->itemnumber, >+ branch => $auto_renew->branchcode, >+ seen => 0, >+ automatic => 1, >+ } >+ ); > push @item_renewal_ids, $auto_renew->itemnumber; > $auto_renew->auto_renew_error(undef)->store; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33444
:
149280
|
151283
|
153593
|
153594
|
153595
|
153597
| 153598 |
153599