Attachment 153660 Details for Bug 33608 – Bug 33608: (follow-up) Default value for interface column

[patch] Bug 33608: (follow-up) Default value for interface column

Bug-33608-follow-up-Default-value-for-interface-co.patch (text/plain), 1.17 KB, created by Martin Renvoize (ashimema) on 2023-07-19 14:11:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-07-19 14:11:22 UTC

Size: 1.17 KB

patch

obsolete

>From 336dce79b2b6d5b36a2485ac4cddd74264959443 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 1 Jun 2023 11:41:54 +0000
>Subject: [PATCH] Bug 33608: (follow-up) Default value for interface column
>
>We should default to C4::Context->interface.
>
>Test plan:
>Login via intranet (see Bugzilla report).
>Edit an item. Set to lost.
>Check entry in statistics table on interface value.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Statistic.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Statistic.pm b/Koha/Statistic.pm
>index 06ada927aa..3da51b4cc5 100644
>--- a/Koha/Statistic.pm
>+++ b/Koha/Statistic.pm
>@@ -101,7 +101,7 @@ sub new {
>         borrowernumber => $params->{borrowernumber}, # no longer sending empty string (changed 2023)
>         categorycode   => $params->{categorycode},
>         ccode          => _key_or_default( $params, 'ccode', q{} ),
>-        interface      => $params->{interface},
>+        interface      => $params->{interface} // C4::Context->interface,
>     });
> }
> 
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 33608: 150840 | 150841 | 150842 | 150843 | 150844 | 150845 | 150846 | 151051 | 151052 | 151053 | 151054 | 151055 | 151056 | 151057 | 151913 | 151915 | 151916 | 151917 | 151918 | 151919 | 151920 | 151921 | 151922 | 153653 | 153654 | 153655 | 153656 | 153657 | 153658 | 153659 | 153660 | 153661 | 153698 | 153699 | 153700 | 153701 | 153702 | 153703 | 153704 | 153705 | 153706 | 153707 | 153708 | 153709 | 153710 | 153711 | 153712 | 153713 | 153765 | 157440 | 157441 | 157442 | 157443 | 157444 | 157445 | 157446 | 157447 | 157448 | 157449