Bugzilla – Attachment 153665 Details for
Bug 34258
Cannot renew item via SIP2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34258: (QA follow-up) Tidy the test
Bug-34258-QA-follow-up-Tidy-the-test.patch (text/plain), 1.87 KB, created by
Martin Renvoize (ashimema)
on 2023-07-19 14:21:47 UTC
(
hide
)
Description:
Bug 34258: (QA follow-up) Tidy the test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-07-19 14:21:47 UTC
Size:
1.87 KB
patch
obsolete
>From 25bb1a61b8f3f35a25c47aaebaa5c2e8b9608411 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 19 Jul 2023 15:20:46 +0100 >Subject: [PATCH] Bug 34258: (QA follow-up) Tidy the test > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/SIP/ILS.t | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > >diff --git a/t/db_dependent/SIP/ILS.t b/t/db_dependent/SIP/ILS.t >index 10f4d28f68..3bc5f63146 100755 >--- a/t/db_dependent/SIP/ILS.t >+++ b/t/db_dependent/SIP/ILS.t >@@ -318,8 +318,8 @@ subtest renew_all => sub { > subtest renew => sub { > plan tests => 2; > >- my $library = $builder->build_object ({ class => 'Koha::Libraries' }); >- my $patron = $builder->build_object( >+ my $library = $builder->build_object( { class => 'Koha::Libraries' } ); >+ my $patron = $builder->build_object( > { > class => 'Koha::Patrons', > value => { >@@ -327,17 +327,19 @@ subtest renew => sub { > } > } > ); >- t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode }); >+ t::lib::Mocks::mock_userenv( { branchcode => $library->branchcode } ); > >- my $item = $builder->build_sample_item({ >- library => $library->branchcode, >- }); >+ my $item = $builder->build_sample_item( >+ { >+ library => $library->branchcode, >+ } >+ ); > > AddIssue( $patron->unblessed, $item->barcode, undef, 0 ); > my $checkout = $item->checkout; >- ok( defined($checkout), "Successfully checked out an item prior to renewal"); >+ ok( defined($checkout), "Successfully checked out an item prior to renewal" ); > >- my $ils = C4::SIP::ILS->new({ id => $library->branchcode }); >+ my $ils = C4::SIP::ILS->new( { id => $library->branchcode } ); > > my $transaction = $ils->renew( $patron->cardnumber, "", $item->barcode ); > >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34258
:
153416
|
153417
|
153427
|
153428
|
153663
|
153664
| 153665