Bugzilla – Attachment 153672 Details for
Bug 31383
Additional contents: We need a parent and child table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31383: (QA follow-up) Do not return 0 in ->get
Bug-31383-QA-follow-up-Do-not-return-0-in--get.patch (text/plain), 1003 bytes, created by
Marcel de Rooy
on 2023-07-19 14:38:13 UTC
(
hide
)
Description:
Bug 31383: (QA follow-up) Do not return 0 in ->get
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-07-19 14:38:13 UTC
Size:
1003 bytes
patch
obsolete
>From 9a0774b2a92a2857fef4bf4c07caf93df0495052 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 21 Jun 2023 11:48:27 +0000 >Subject: [PATCH] Bug 31383: (QA follow-up) Do not return 0 in ->get >Content-Type: text/plain; charset=utf-8 > >The last statement evaluated is the if( $content->count ). >If that evaluates to false, the false expression value is returned. >In this case that is 0. >We should just return undef or empty list (scalar/list context). > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Template/Plugin/AdditionalContents.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/Koha/Template/Plugin/AdditionalContents.pm b/Koha/Template/Plugin/AdditionalContents.pm >index 455ba848e1..6d25255a2e 100644 >--- a/Koha/Template/Plugin/AdditionalContents.pm >+++ b/Koha/Template/Plugin/AdditionalContents.pm >@@ -53,6 +53,7 @@ sub get { > blocktitle => $blocktitle > }; > } >+ return; > } > > sub get_opac_news_by_id { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31383
:
147891
|
147892
|
147893
|
147894
|
147895
|
147896
|
149813
|
149814
|
149815
|
149816
|
149817
|
149818
|
152423
|
152424
|
152425
|
152426
|
152427
|
152428
|
152545
|
152546
|
152547
|
152566
|
152660
|
152661
|
152662
|
152663
|
152664
|
152665
|
152666
|
152667
|
152668
|
152669
|
153013
|
153666
|
153667
|
153668
|
153669
|
153670
|
153671
|
153672
|
153673
|
153674
|
153675
|
153676
|
156048
|
156049
|
156050
|
156051
|
156052
|
156053
|
156054
|
156055
|
156056
|
156057
|
156058
|
156265
|
156266
|
156267
|
156268
|
156269
|
156270
|
156271
|
156272
|
156273
|
156274
|
156275
|
156276
|
157539
|
157540
|
157541
|
157542
|
157543
|
157544
|
157545
|
157546
|
157547
|
157548
|
157549
|
157550
|
157580
|
157585
|
157640
|
157741
|
157742