Attachment 153766 Details for Bug 33940 – Bug 33940: (QA follow-up) Remove obsolete length of 20

[patch] Bug 33940: (QA follow-up) Remove obsolete length of 20

Bug-33940-QA-follow-up-Remove-obsolete-length-of-2.patch (text/plain), 1.17 KB, created by Marcel de Rooy on 2023-07-21 09:45:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-07-21 09:45:32 UTC

Size: 1.17 KB

patch

obsolete

>From 13a6eb56a3daa4eba6b06a4c037afe3dd3a5df2e Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 21 Jul 2023 09:44:18 +0000
>Subject: [PATCH] Bug 33940: (QA follow-up) Remove obsolete length of 20
>Content-Type: text/plain; charset=utf-8
>
>Currently 32. Could be 43 tomorrow :)
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Policy/Patrons/Cardnumber.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Policy/Patrons/Cardnumber.pm b/Koha/Policy/Patrons/Cardnumber.pm
>index 1d3ec4cbe3..99cfffcfb1 100644
>--- a/Koha/Policy/Patrons/Cardnumber.pm
>+++ b/Koha/Policy/Patrons/Cardnumber.pm
>@@ -85,7 +85,7 @@ sub get_valid_length {
>     my ($class)    = @_;
>     my $borrower   = Koha::Database->new->schema->resultset('Borrower');
>     my $field_size = $borrower->result_source->column_info('cardnumber')->{size};
>-    my ( $min, $max ) = ( 0, $field_size );    # borrowers.cardnumber is a nullable varchar(20)
>+    my ( $min, $max ) = ( 0, $field_size );
>     $min = 1 if C4::Context->preference('BorrowerMandatoryField') =~ /cardnumber/;
>     if ( my $cardnumber_length = C4::Context->preference('CardnumberLength') ) {
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33940: 152109 | 153758 | 153759 | 153763 | 153764 | 153766 | 153768 | 153769 | 153770 | 153771 | 153772 | 153773 | 155687 | 155688 | 155689