Bugzilla – Attachment 153810 Details for
Bug 29145
Allow patrons to have overdue items that would not result in debarment when removing overdue debarments
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29145: (QA follow-up) Rename has_debarring_overdues to has_restricting_overdues
Bug-29145-QA-follow-up-Rename-hasdebarringoverdues.patch (text/plain), 1.81 KB, created by
Katrin Fischer
on 2023-07-21 16:36:29 UTC
(
hide
)
Description:
Bug 29145: (QA follow-up) Rename has_debarring_overdues to has_restricting_overdues
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-07-21 16:36:29 UTC
Size:
1.81 KB
patch
obsolete
>From 3f8ccff0ba2e652766c03e36ab379e7d7bdd9778 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 27 Jan 2023 09:22:59 -0500 >Subject: [PATCH] Bug 29145: (QA follow-up) Rename has_debarring_overdues to > has_restricting_overdues > >--- > C4/Circulation.pm | 2 +- > Koha/Patron.pm | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 77953e5812..08e7e49ac7 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2636,7 +2636,7 @@ sub MarkIssueReturned { > if (C4::Context->preference('AutoRemoveOverduesRestrictions') ne 'no' && $patron->is_debarred) { > my $remove_restrictions = > C4::Context->preference('AutoRemoveOverduesRestrictions') eq 'when_no_overdue_causing_debarment' ? >- !$patron->has_debarring_overdues({ issue_branchcode => $issue_branchcode }) : >+ !$patron->has_restricting_overdues({ issue_branchcode => $issue_branchcode }) : > !$patron->has_overdues; > if ( > $remove_restrictions && $overdue_restrictions->count >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index a2c99d2c12..3f1621f961 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -1000,15 +1000,15 @@ sub has_overdues { > } > > >-=head3 has_debarring_overdues >+=head3 has_restricting_overdues > >-my $has_debarring_overdues = $patron->has_debarring_overdues({ issue_branchcode => $branchcode }); >+my $has_restricting_overdues = $patron->has_restricting_overdues({ issue_branchcode => $branchcode }); > > Returns true if patron has overdues that would result in debarment. > > =cut > >-sub has_debarring_overdues { >+sub has_restricting_overdues { > my ($self, $params) = @_; > $params //= {}; > my $date = dt_from_string()->truncate( to => 'day' ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29145
:
125495
|
140819
|
140820
|
141822
|
141823
|
142394
|
142395
|
142396
|
142814
|
142815
|
142816
|
142817
|
143213
|
144773
|
144774
|
144775
|
144776
|
144777
|
144778
|
144779
|
144780
|
144781
|
144782
|
145720
|
145749
|
145750
|
145751
|
153804
|
153805
|
153806
|
153807
|
153808
|
153809
|
153810
|
153811
|
153812
|
153813
|
153814
|
156392
|
156393
|
156394
|
156395
|
156396
|
156397
|
156398
|
156399
|
156400
|
156401
|
156402
|
156403
|
156404