Bugzilla – Attachment 153860 Details for
Bug 34368
Add CSRF protection to Content Management pages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34368: Add CSRF token to Content Management pages
Bug-34368-Add-CSRF-token-to-Content-Management-pag.patch (text/plain), 3.27 KB, created by
Jonathan Druart
on 2023-07-25 06:18:43 UTC
(
hide
)
Description:
Bug 34368: Add CSRF token to Content Management pages
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-07-25 06:18:43 UTC
Size:
3.27 KB
patch
obsolete
>From 57e4df6a35a5d9d2645650a0c7dd2bb6c2f4d215 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 25 Jul 2023 05:18:00 +0000 >Subject: [PATCH] Bug 34368: Add CSRF token to Content Management pages > >This change adds a CSRF token to the Content Management pages >at additional-contents.pl. > >Test plan: >0. Apply patch >1. koha-plack --restart kohadev >2. Try to add "News", "HTML customizations", and "Pages". >3. Try to delete these new content entries >4. Note that you were successful in your endeavours > >JD amended patch: remove empty line removal (no need to create >unecessary conflicts) > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/en/modules/tools/additional-contents.tt | 2 ++ > tools/additional-contents.pl | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >index 84cda9311dc..650ee9de53c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >@@ -201,6 +201,7 @@ > </div> > > <form id="add_additional_content" method="post" action="/cgi-bin/koha/tools/additional-contents.pl" class="validate"> >+ [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="op" value="add_validate" /> > <input type="hidden" name="category" value="[% category | html %]" /> > <input type="hidden" name="code" value="[% additional_content.code | html %]" /> >@@ -454,6 +455,7 @@ > <fieldset class="action"><input type="submit" class="btn btn-primary" value="Delete selected" /></fieldset> > </form> > <form action="/cgi-bin/koha/tools/additional-contents.pl" method="post" id="delete_single"> >+ [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" id="del_op" name="op" value="delete_confirmed" /> > <input type="hidden" id="del_category" name="category" value="[% category | html %]" /> > <input type="hidden" id="del_ids" name="ids" /> >diff --git a/tools/additional-contents.pl b/tools/additional-contents.pl >index 46f358f9d79..e066bb8fee9 100755 >--- a/tools/additional-contents.pl >+++ b/tools/additional-contents.pl >@@ -28,7 +28,7 @@ use C4::Auth qw(get_template_and_user); > use C4::Koha; > use C4::Context; > use C4::Log qw( logaction ); >-use C4::Output qw(output_html_with_http_headers); >+use C4::Output qw(output_html_with_http_headers output_and_exit_if_error); > use C4::Languages qw(getTranslatedLanguages); > use Koha::DateUtils qw( dt_from_string output_pref ); > >@@ -84,6 +84,7 @@ if ( $op eq 'add_form' ) { > ); > } > elsif ( $op eq 'add_validate' ) { >+ output_and_exit_if_error($cgi, $cookie, $template, { check => 'csrf_token' }); > my $location = $cgi->param('location'); > my $code = $cgi->param('code'); > my $branchcode = $cgi->param('branchcode') || undef; >@@ -199,6 +200,7 @@ elsif ( $op eq 'add_validate' ) { > } > } > elsif ( $op eq 'delete_confirmed' ) { >+ output_and_exit_if_error($cgi, $cookie, $template, { check => 'csrf_token' }); > my @ids = $cgi->multi_param('ids'); > my $deleted = eval { > >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34368
:
153859
|
153860
|
153866
|
154043