Attachment 153934 Details for Bug 26994 – Bug 26994: List names in alphabetical order in Suggestion filter

[patch] Bug 26994: List names in alphabetical order in Suggestion filter

Bug-26994-List-names-in-alphabetical-order-in-Sugg.patch (text/plain), 1.27 KB, created by Shi Yao Wang on 2023-07-26 17:12:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shi Yao Wang

Created: 2023-07-26 17:12:49 UTC

Size: 1.27 KB

patch

obsolete

>From ce729c14985c3a6bcea7f32a3f472a42a1f4bd51 Mon Sep 17 00:00:00 2001
>From: Shi Yao Wang <shi-yao.wang@inlibro.com>
>Date: Wed, 26 Jul 2023 12:58:39 -0400
>Subject: [PATCH] Bug 26994: List names in alphabetical order in Suggestion
> filter
>
>Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management
>
>Test plan:
>1. Add different purchase suggestions from various patron's names
>2. Go to Acquisition > Suggestions
>3. Click on the Suggestion information filters on the left-hand side
>4. Use one of these drop-down menus: "Suggested by" or, "Managed by" or "Accepted by"
>--> notice the list of names in menus, names aren't displayed from A to Z
>5. Apply patch and refresh page
>6. Redo step 4
>--> notice now it's sorted alphabetically
>---
> suggestion/suggestion.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl
>index b2cbf3a639..76d3eb7293 100755
>--- a/suggestion/suggestion.pl
>+++ b/suggestion/suggestion.pl
>@@ -524,6 +524,7 @@ foreach my $field ( qw(managedby acceptedby suggestedby budgetid) ) {
>     } grep {
>         $$_{'value'}
>     } @$values_list;
>+    @codes_list = sort { $a->{desc} cmp $b->{desc} } @codes_list;
>     $hashlists{ lc($field) . "_loop" } = \@codes_list;
> }
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 26994: 153934 | 154296 | 156703