Attachment 154056 Details for Bug 33140 – Bug 33140: Use facet label value for mouseover text on facet removal link

[patch] Bug 33140: Use facet label value for mouseover text on facet removal link

Bug-33140-Use-facet-label-value-for-mouseover-text.patch (text/plain), 3.50 KB, created by Katrin Fischer on 2023-07-29 17:41:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-07-29 17:41:22 UTC

Size: 3.50 KB

patch

obsolete

>From 0b6199cc08d039dfa719ade66ebc78c3457a88f6 Mon Sep 17 00:00:00 2001
>From: Andreas Jonsson <andreas.jonsson@kreablo.se>
>Date: Sun, 5 Mar 2023 13:21:34 +0100
>Subject: [PATCH] Bug 33140: Use facet label value for mouseover text on facet
> removal link
>
>This patch updates the facets includes in both the staff interface and
>OPAC so that the title attribute on "remove" links uses the full name
>rather than the code of the facet. So, library name instead of
>branchcode, collection code description instead of authorized value
>code.
>
>To test, apply the patch and perform a search in the staff interface.
>
>- Click a facet in the left-hand sidebar which will return more than one
> result.
> - On the reloaded page there should be a link next to that facet: [X].
> Hovering your mouse over it should show "Remove facet [facet name]"
> e.g. "Remove facet Centerville" instead of "Remove facet CPL"
>- Test on library facets, item type facets, and collection code facets.
>- Perform the same test in the OPAC.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>index 2c56036f04..7330b3dc4c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc
>@@ -62,7 +62,7 @@
> [% IF facet.active %]
> [% local_url = BLOCK %][% url | $raw %][% "&nolimit=" _ facet.type_link_value _ ":" _ facet.facet_link_value | url %][% END %]
> [% facet.facet_label_value | html %]
>- [<a href="[% local_url | $raw %]" title="Remove facet [% facet.facet_link_value | html %]">x</a>]
>+ [<a href="[% local_url | $raw %]" title="Remove facet [% facet.facet_label_value | html %]">x</a>]
> [% ELSE %]
> [% local_url = BLOCK %][% url | $raw %][% "&limit=" _ facet.type_link_value _ ":" _ facet.facet_link_value | url %][% END %]
> <a href="[% local_url | $raw %]" title="[% facet.facet_title_value | html %]">[% facet.facet_label_value | html %]</a>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>index 844de90853..37aa75d823 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>@@ -73,7 +73,7 @@
> [% IF ( displayFacetCount ) %]
> ([% facet.facet_count | html %])
> [% END %]
>- [<a href="[% local_url | $raw %]" title="Remove facet [% facet.facet_link_value | html %]">x</a>]
>+ [<a href="[% local_url | $raw %]" title="Remove facet [% facet.facet_label_value | html %]">x</a>]
> [% ELSE %]
> [% local_url = BLOCK %][% url | $raw %][% "&limit=" _ facet.type_link_value _ ":" _ facet.facet_link_value | url %][% END %]
> <a href="[% local_url | $raw %]" title="[% facet.facet_title_value | html %]">[% facet.facet_label_value | html %]</a>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33140: 147773 | 153927 | 154056