Attachment 154128 Details for Bug 34436 – Bug 34436: Some breadcrumbs lack for translatability

[patch] Bug 34436: Some breadcrumbs lack for translatability

Bug-34436-Some-breadcrumbs-lack-span-for-translata.patch (text/plain), 8.72 KB, created by Sam Lau on 2023-08-01 14:35:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Lau

Created: 2023-08-01 14:35:47 UTC

Size: 8.72 KB

patch

obsolete

>From d2f1a6e1997e7acf24937d299aa7e67218fd2f47 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 27 Jul 2023 16:11:54 +0000
>Subject: [PATCH] Bug 34436: Some breadcrumbs lack for translatability
>
>This patch modifies several templates which were updated recently so
>that breadcrumbs markup could be built using template wrappers. The
>patch wraps strings in in cases where it is necessary to make
>them translatable.
>
>To test, apply the patch and view the following pages to confirm that
>the breadcrumbs still show up correctly:
>
>- Administration -> MARC bibliographic framework
> - Add framework
> - Edit framework
> - Delete framework
>- Administration -> Share content with Mana KB
>- Administration -> Circulation and fine rules
>- Authorities ->
> - Add authority
> - Edit authority
>- Catalog -> Advanced search
> - Bibliographic detail page
> - Must have EasyAnalyticalRecords enabled.
> - Edit -> Link to host record
>- Patrons
>- Reports -> Average loan time
>- Serials -> Serials home
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>---
> .../prog/en/modules/admin/biblio_framework.tt | 8 ++++----
> .../intranet-tmpl/prog/en/modules/admin/share_content.tt | 2 +-
> .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +-
> .../prog/en/modules/authorities/authorities.tt | 4 ++--
> .../intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +-
> .../intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 2 +-
> .../prog/en/modules/reports/issues_avg_stats.tt | 4 ++--
> .../intranet-tmpl/prog/en/modules/serials/serials-home.tt | 2 +-
> 9 files changed, 14 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
>index 5ba2841c41..e053fb7ec2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
>@@ -32,11 +32,11 @@ MARC frameworks &rsaquo; Administration &rsaquo; Koha
> [% END %]
> [% IF framework %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Modify framework text
>+ Modify framework text
> [% END %]
> [% ELSE %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Add framework
>+ Add framework
> [% END %]
> [% END %]
> 
>@@ -45,12 +45,12 @@ MARC frameworks &rsaquo; Administration &rsaquo; Koha
> <a href="/cgi-bin/koha/admin/biblio_framework.pl">MARC frameworks</a>
> [% END %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])?
>+ Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])?
> [% END %]
> 
> [% ELSE %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- MARC frameworks
>+ MARC frameworks
> [% END %]
> [% END %]
> [% END #/ WRAPPER breadcrumbs %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt
>index cea35c77e2..a8fcbbdebe 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt
>@@ -18,7 +18,7 @@
> <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a>
> [% END %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Share content with Mana KB
>+ Share content with Mana KB
> [% END %]
> [% END #/ WRAPPER breadcrumbs %]
> [% END #/ WRAPPER sub-header.inc %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 3ffde1caa3..1a6cdf89e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -39,7 +39,7 @@
> <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a>
> [% END %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Circulation and fine rules
>+ Circulation and fine rules
> [% END %]
> [% END #/ WRAPPER breadcrumbs %]
> [% END #/ WRAPPER sub-header.inc %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>index 6c8f454b01..c58c7dca23 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>@@ -361,12 +361,12 @@
> 
> [% IF ( authid ) %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Modify authority #[% authid | html %] ([% authtypetext | html %])
>+ Modify authority #[% authid | html %] ([% authtypetext | html %])
> [% END %]
> 
> [% ELSE %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Adding authority [% authtypetext | html %]
>+ Adding authority [% authtypetext | html %]
> [% END %]
> 
> [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
>index 1db0c2f371..d7b340b58a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
>@@ -33,7 +33,7 @@
> [% WRAPPER 'sub-header.inc' %]
> [% WRAPPER breadcrumbs %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Advanced search
>+ Advanced search
> [% END %]
> [% END #/ WRAPPER breadcrumbs %]
> [% END #/ WRAPPER sub-header.inc %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt
>index 78927bc3f1..b74519b122 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt
>@@ -15,7 +15,7 @@
> <a href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cataloging</a>
> [% END %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Link a host record to [% bibliotitle | html %]
>+ Link a host record to [% bibliotitle | html %]
> [% END %]
> [% END #/ WRAPPER breadcrumbs %]
> [% END #/ WRAPPER sub-header.inc %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>index 6d664186cb..53670d10e0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>@@ -24,7 +24,7 @@
> [% WRAPPER 'sub-header.inc' %]
> [% WRAPPER breadcrumbs %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Patrons
>+ Patrons
> [% END %]
> [% END #/ WRAPPER breadcrumbs %]
> [% END #/ WRAPPER sub-header.inc %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt
>index d647883a0d..3b98f0be2c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt
>@@ -21,11 +21,11 @@
> <a href="/cgi-bin/koha/reports/issues_avg_stats.pl">Average loan time</a>
> [% END %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Results
>+ Results
> [% END %]
> [% ELSE %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Average loan time
>+ Average loan time
> [% END %]
> [% END %]
> [% END #/ WRAPPER breadcrumbs %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt
>index 9f5080736b..a9a7c7e061 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt
>@@ -16,7 +16,7 @@
> [% WRAPPER 'sub-header.inc' %]
> [% WRAPPER breadcrumbs %]
> [% WRAPPER breadcrumb_item bc_active= 1 %]
>- Serials
>+ Serials
> [% END %]
> [% END #/ WRAPPER breadcrumbs %]
> [% END #/ WRAPPER sub-header.inc %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34436: 153996 | 154128 | 154133 | 154134