Bugzilla – Attachment 154138 Details for
Bug 30362
GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30362: Fix unit test
Bug-30362-Fix-unit-test.patch (text/plain), 1.30 KB, created by
Katrin Fischer
on 2023-08-01 21:45:19 UTC
(
hide
)
Description:
Bug 30362: Fix unit test
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-08-01 21:45:19 UTC
Size:
1.30 KB
patch
obsolete
>From 27b12b94412957860800e949b10d78c28087afed Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 20 Jul 2023 02:39:18 +0000 >Subject: [PATCH] Bug 30362: Fix unit test > >Signed-off-by: Sam Lau <samalau@gmail.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/db_dependent/Circulation.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 7b1e063da3..f9a7c49a9d 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -5788,7 +5788,7 @@ subtest "SendCirculationAlert" => sub { > }; > > subtest "GetSoonestRenewDate tests" => sub { >- plan tests => 5; >+ plan tests => 6; > Koha::CirculationRules->set_rule( > { > categorycode => undef, >@@ -5871,8 +5871,8 @@ subtest "GetSoonestRenewDate tests" => sub { > ); > $issue->date_due( dt_from_string )->store; > is( >- GetSoonestRenewDate( $patron->id, $item->itemnumber ), >- dt_from_string->truncate( to => 'day' ), >+ GetSoonestRenewDate( $patron, $issue ), >+ dt_from_string->subtract( days => 1 )->truncate( to => 'day' ), > 'Checkouts with auto-renewal can be renewed 1 day before due date if no renewalbefore = 1 and precision = "date"' > ); > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30362
:
132248
|
153694
|
153695
|
153736
|
153737
|
153738
|
154136
|
154137
| 154138 |
154139