Bugzilla – Attachment 154218 Details for
Bug 34108
When items are added on order, item selection gets lost on editing items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34108: Preserve checked orders after item editing
Bug-34108-Preserve-checked-orders-after-item-editi.patch (text/plain), 1.79 KB, created by
Nick Clemens (kidclamp)
on 2023-08-03 12:30:18 UTC
(
hide
)
Description:
Bug 34108: Preserve checked orders after item editing
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-08-03 12:30:18 UTC
Size:
1.79 KB
patch
obsolete
>From cb03eecebf7e7fec2681b0cee6dae8a0bdf1d28a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 3 Aug 2023 12:26:17 +0000 >Subject: [PATCH] Bug 34108: Preserve checked orders after item editing > >The js that buils the new row after editing expects to receive a >value '_checked' indicating if theitem was selected. The 'item' variable >used to create the row after edit comes from the api and doesn't include this. > >We need to inspect the previous html before building the new row to confirm the box wa checked > >To test: > 1 - Create a basket with 'items created on receive' > 2 - Add an order line with multiple items to it > 3 - Close basket > 4 - Receive shipment > 5 - Add invoice information > 6 - Receive through receive link in the table > 7 - Check some items > 8 - Click on the "Edit" link and make some change to the item > 9 - Save >10 - Checkboxes have disappeared >11 - Cancel receipt >12 - Apply patch >13 - Reload the page >14 - Repeat 7-9 >15 - Checkbox is preserved >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index 724ae61607..a7b9db35e4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -499,6 +499,7 @@ > url: '/api/v1/items/'+itemnumber, > success: function(item) { > var tr = $("#item_"+itemnumber); >+ item._checked = $(tr).find('input[type="checkbox"]').prop('checked'); > tr.html(''); > _build_item(item, tr); > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34108
:
154218
|
154220
|
154225
|
154262