Bugzilla – Attachment 154219 Details for
Bug 34470
Real Time Holds Queue - make random numbers play nice with forked processes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34470: [DO NOT PUSH] Add logging to watch randomization
Bug-34470-DO-NOT-PUSH-Add-logging-to-watch-randomi.patch (text/plain), 1.40 KB, created by
Emily Lamancusa (emlam)
on 2023-08-03 14:30:24 UTC
(
hide
)
Description:
Bug 34470: [DO NOT PUSH] Add logging to watch randomization
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2023-08-03 14:30:24 UTC
Size:
1.40 KB
patch
obsolete
>From 837c215477cfa170a7831fc85c77a27a002c835e Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Thu, 3 Aug 2023 10:28:30 -0400 >Subject: [PATCH] Bug 34470: [DO NOT PUSH] Add logging to watch randomization > >--- > C4/HoldsQueue.pm | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index 4b811627eb..a78ea7482a 100644 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -33,6 +33,13 @@ use Koha::Patrons; > use List::Util qw( shuffle ); > use List::MoreUtils qw( any ); > >+use Data::Dumper; >+use Koha::Logger; >+ >+$Data::Dumper::Maxdepth = 2; >+C4::Context->interface('intranet'); >+my $logger = Koha::Logger->get(); >+ > our (@ISA, @EXPORT_OK); > BEGIN { > require Exporter; >@@ -813,8 +820,12 @@ sub load_branches_to_pull_from { > ->get_column('branchcode')->all() > unless (@branches_to_use); > >- @branches_to_use = shuffle(@branches_to_use) >- if C4::Context->preference("RandomizeHoldsQueueWeight"); >+ if(C4::Context->preference("RandomizeHoldsQueueWeight")) { >+ $logger->warn("Branch list before shuffle:" . Dumper(@branches_to_use)); >+ @branches_to_use = shuffle(@branches_to_use); >+ $logger->warn("Branch list after shuffle:" . Dumper(@branches_to_use)); >+ } >+ > > my $today = dt_from_string(); > if ( C4::Context->preference('HoldsQueueSkipClosed') ) { >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34470
: 154219 |
154335
|
154336
|
154339